crypto: af_alg - Disallow bind/setkey/... after accept(2)

Browse source

[ Upstream commit c840ac6af3 ]

Each af_alg parent socket obtained by socket(2) corresponds to a
tfm object once bind(2) has succeeded.  An accept(2) call on that
parent socket creates a context which then uses the tfm object.

Therefore as long as any child sockets created by accept(2) exist
the parent socket must not be modified or freed.

This patch guarantees this by using locks and a reference count
on the parent socket.  Any attempt to modify the parent socket will
fail with EBUSY.

Cc: stable@vger.kernel.org
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

...

This commit is contained in:

Herbert Xu 2015-12-30 11:47:53 +08:00 • committed by Sasha Levin

parent 9044efa964

commit f857638dd7

2 changed files with 35 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

35

crypto/af_alg.c

View file

8

include/crypto/if_alg.h

View file