selftests/bpf: convert test_skb_cgroup_id_user to test_progs

Browse source

test_skb_cgroup_id_user allows testing skb cgroup id retrieval at different
levels, but is not integrated in test_progs, so it is not run
automatically in CI. The test overlaps a bit with
cgroup_skb_sk_lookup_kern, which is integrated in test_progs and test
extensively skb cgroup helpers, but there is still one major difference
between the two tests which justifies the conversion:
cgroup_skb_sk_lookup_kern deals with a BPF_PROG_TYPE_CGROUP_SKB (attached
on a cgroup), while test_skb_cgroup_id_user deals with a
BPF_PROG_TYPE_SCHED_CLS (attached on a qdisc)

Convert test_skb_cgroup_id_user into test_progs framework in order to run
it automatically in CI. The main differences with the original test are the
following:
- rename the test to make it shorter and more straightforward regarding
  tested feature
- the wrapping shell script has been dropped since every setup step is now
  handled in the main C test file
- the test has been renamed for a shorter name and reflecting the tested
  API
- add dedicated assert log per level to ease test failure debugging
- use global variables instead of maps to access bpf prog data

Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>
Link: https://lore.kernel.org/r/20240813-convert_cgroup_tests-v4-4-a33c03458cf6@bootlin.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>

...

This commit is contained in:

Alexis Lothoré (eBPF Foundation) 2024-08-13 14:45:08 +02:00 • committed by Martin KaFai Lau

parent 7b4400a0a6

commit f957c230e1

6 changed files with 160 additions and 276 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

tools/testing/selftests/bpf/.gitignore vendored

View file

3

tools/testing/selftests/bpf/Makefile

View file

141

tools/testing/selftests/bpf/prog_tests/cgroup_ancestor.c

View file

41

tools/testing/selftests/bpf/progs/cgroup_ancestor.c

View file

67

tools/testing/selftests/bpf/test_skb_cgroup_id.sh

View file

183

tools/testing/selftests/bpf/test_skb_cgroup_id_user.c

View file