bcachefs: Fix a deadlock in bch2_btree_node_get_sibling()

Browse source

There was a bad interaction with bch2_btree_iter_set_pos_same_leaf(),
which can leave a btree node locked that is just outside iter->pos,
breaking the lock ordering checks in __bch2_btree_node_lock(). Ideally
we should get rid of this corner case, but for now fix it locally with
verbose comments.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2020-06-02 19:41:47 -04:00 • committed by Kent Overstreet

parent 495aabede3

commit f96c0df4db

4 changed files with 29 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

12

fs/bcachefs/btree_cache.c

View file

18

fs/bcachefs/btree_iter.c

View file

9

fs/bcachefs/btree_iter.h

View file

1

fs/bcachefs/btree_types.h

View file