drm/i915: simplify dvo dpms interface

Browse source

All dvo drivers only support 2 dpms states, and our dvo driver
even switches of the dvo port for anything else than DPMS_ON. Hence
ditch this complexity and simply use bool enable.

While reading through this code I've noticed that the mode_set
function of ch7017 is a bit peculiar - it disable the lvds again, even
though the crtc helper code should have done that ... This might be to
work around an issue at driver load, we pretty much ignore the hw
state when taking over.

v2: Also do the conversion for the new ns2501 driver.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

...

This commit is contained in:

Daniel Vetter 2012-08-12 19:27:12 +02:00

parent d2434ab7fb

commit fac3274c4e

8 changed files with 26 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/gpu/drm/i915/dvo.h

View file

8

drivers/gpu/drm/i915/dvo_ch7017.c

View file

4

drivers/gpu/drm/i915/dvo_ch7xxx.c

View file

8

drivers/gpu/drm/i915/dvo_ivch.c

View file

14

drivers/gpu/drm/i915/dvo_ns2501.c

View file

4

drivers/gpu/drm/i915/dvo_sil164.c

View file

4

drivers/gpu/drm/i915/dvo_tfp410.c

View file

4

drivers/gpu/drm/i915/intel_dvo.c

View file