s390/sysinfo,topology: fix cpu topology maximum nesting detection

Browse source

The maximum nesting of the cpu topology is evaluated when /proc/sysinfo
is the first time read. This happens without a lock and a concurrent
reader on a different cpu can see and use an invalid intermediate value.
Besides the fact that this race is quite unlikely the worst thing that
could happen is that /proc/sysinfo would contain bogus information about
the machine's cpu topology.
Nevertheless this should be fixed. So move the detection code to the
early machine detection code and since now the value is early available
use it in the topology code as well.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

...

This commit is contained in:

Heiko Carstens 2012-09-04 14:26:03 +02:00 • committed by Martin Schwidefsky

parent 34cda99260

commit fade4dc491

4 changed files with 31 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/s390/include/asm/sysinfo.h

View file

27

arch/s390/kernel/early.c

View file

12

arch/s390/kernel/sysinfo.c

View file

10

arch/s390/kernel/topology.c

View file