nfsd: close potential race in nfsd4_free_stateid

Browse source

Once we remove the client_mutex, it'll be possible for the sc_type of a
lock stateid to change after it's found and checked, but before we can
go to destroy it. If that happens, we can end up putting the persistent
reference to the stateid more than once, and unhash it more than once.

Fix this by unhashing the lock stateid prior to dropping the cl_lock but
after finding it.

Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

Jeff Layton 2014-07-29 21:34:40 -04:00 • committed by J. Bruce Fields

parent 3c1c995cc2

commit fc5a96c3b7

1 changed files with 9 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

fs/nfsd/nfs4state.c

View file