fix historic ioremap() abuse in AGP

Browse source

Several AGP drivers right now use ioremap_nocache() on kernel ram in order
to turn a page of regular memory uncached.

There are two problems with this:

    1) This is a total nightmare for the ioremap() implementation to keep
       various mappings of the same page coherent.

    2) It's a total nightmare for the AGP code since it adds a ton of
       complexity in terms of keeping track of 2 different pointers to
       the same thing, in terms of error handling etc etc.

This patch fixes this by making the AGP drivers use the new
set_memory_XX APIs instead.

Note: amd-k7-agp.c is built on Alpha too, and generic.c is built
on ia64 as well, which do not yet have the set_memory_*() APIs,
so for them some we have a few ugly #ifdefs - hopefully they'll
be fixed soon.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Dave Airlie <airlied@linux.ie>

...

This commit is contained in:

Arjan van dev Ven 2008-02-06 05:16:00 +01:00 • committed by Dave Airlie

parent 16469a0ea0

commit fcea424d31

5 changed files with 28 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/x86/mm/ioremap.c

View file

9

drivers/char/agp/amd-k7-agp.c

View file

16

drivers/char/agp/ati-agp.c

View file

9

drivers/char/agp/generic.c

View file

18

drivers/char/agp/sworks-agp.c

View file