bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

Browse source

Code includes wmb() followed by writel(). writel() already has a barrier on
some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Create a new wrapper function with relaxed write operator. Use the new
wrapper when a write is following a wmb().

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Also add mmiowb() so that write code doesn't move outside of scope.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Sinan Kaya 2018-03-25 10:39:20 -04:00 • committed by David S. Miller

parent e42d8cee34

commit fd141fa47c

2 changed files with 10 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/broadcom/bnxt/bnxt.c

View file

9

drivers/net/ethernet/broadcom/bnxt/bnxt.h

View file