qed: Fix race with multiple VFs

Browse source

A PF syncronizes all IOV activity relating to its VFs
by using a single workqueue handling the work.
The workqueue would reach a bitmask of pending VF events
and act upon each in turn.

Problem is that the indication of a VF message [which sets
the 'vf event' bit for that VF] arrives and is set in
the slowpath attention context, which isn't syncronized with
the processing of the events.
When multiple VFs are present, it's possible that PF would
lose the indication of one of the VF's pending evens, leading
that VF to later timeout.

Instead of adding locks/barriers, simply move from a bitmask
into a per-VF indication inside that VF entry in the PF database.

Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Mintz, Yuval 2017-02-27 11:06:32 +02:00 • committed by David S. Miller

parent 4ca257eed6

commit fd3c615ae1

2 changed files with 26 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

39

drivers/net/ethernet/qlogic/qed/qed_sriov.c

View file

4

drivers/net/ethernet/qlogic/qed/qed_sriov.h

View file