drm: omapdrm: Export correct scatterlist for TILER backed BOs

Browse source

Memory of BOs backed by TILER is not contiguous, but omap_gem_map_dma_buf()
exports it like it is. This leads to (possibly) invalid memory accesses if
another device imports such a BO.

Fix that by providing sg that correctly describes TILER memory layout.
Align TILER allocations to page, so importer to be able to correctly set
its MMU if have one. Set export size accounting for the alignment. Also,
make sure to destroy sg on unpin, as it is no longer valid.

Tested on Motorola Droid4 by using GPU (sgx540) to render.

Suggested-by: Matthijs van Duin <matthijsvanduin@gmail.com>
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1637309180-31032-1-git-send-email-ivo.g.dimitrov.75@gmail.com

...

This commit is contained in:

Ivaylo Dimitrov 2021-11-19 10:06:20 +02:00 • committed by Tomi Valkeinen

parent f8378c0403

commit fe4d0b6317

3 changed files with 85 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

79

drivers/gpu/drm/omapdrm/omap_gem.c

View file

2

drivers/gpu/drm/omapdrm/omap_gem.h

View file

34

drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c

View file