Btrfs: do not hold the write_lock on the extent tree while logging

Browse source

Dave Sterba pointed out a sleeping while atomic bug while doing fsync.  This
is because I'm an idiot and didn't realize that rwlock's were spin locks, so
we've been holding this thing while doing allocations and such which is not
good.  This patch fixes this by dropping the write lock before we do
anything heavy and re-acquire it when it is done.  We also need to take a
ref on the em's in case their corresponding pages are evicted and mark them
as being logged so that releasepage does not remove them and doesn't remove
them from our local list.  Thanks,

Reported-by: Dave Sterba <dave@jikos.cz>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>

...

This commit is contained in:

Josef Bacik 2012-09-14 12:59:20 -04:00 • committed by Chris Mason

parent 98114659e0

commit ff44c6e36d

3 changed files with 20 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

fs/btrfs/extent_map.c

View file

1

fs/btrfs/extent_map.h

View file

21

fs/btrfs/tree-log.c

View file