Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

David Gow 0cc5da7990 drm: test: Fix 32-bit issue in drm_buddy_test ... [ Upstream commit 25bbe844ef ] The drm_buddy_test KUnit tests verify that returned blocks have sizes which are powers of two using is_power_of_2(). However, is_power_of_2() operations on a 'long', but the block size is a u64. So on systems where long is 32-bit, this can sometimes fail even on correctly sized blocks. This only reproduces randomly, as the parameters passed to the buddy allocator in this test are random. The seed 0xb2e06022 reproduced it fine here. For now, just hardcode an is_power_of_2() implementation using x & (x - 1). Signed-off-by: David Gow <davidgow@google.com> Acked-by: Christian König <christian.koenig@amd.com> Reviewed-by: Maíra Canal <mcanal@igalia.com> Reviewed-by: Arunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230329065532.2122295-2-davidgow@google.com Signed-off-by: Christian König <christian.koenig@amd.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2023-04-26 14:28:36 +02:00
..
.kunitconfig	drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()	2022-06-27 13:45:53 +02:00
drm_buddy_test.c	drm: test: Fix 32-bit issue in drm_buddy_test	2023-04-26 14:28:36 +02:00
drm_cmdline_parser_test.c	drm/tests: Change "igt_" prefix to "drm_test_"	2022-09-14 13:53:33 -03:00
drm_damage_helper_test.c	drm/tests: Change "igt_" prefix to "drm_test_"	2022-09-14 13:53:33 -03:00
drm_dp_mst_helper_test.c	drm/tests: Change "igt_" prefix to "drm_test_"	2022-09-14 13:53:33 -03:00
drm_format_helper_test.c	drm: tests: Fix a buffer overflow in format_helper_test	2022-10-20 09:56:05 +02:00
drm_format_test.c	drm/tests: Change "igt_" prefix to "drm_test_"	2022-09-14 13:53:33 -03:00
drm_framebuffer_test.c	drm/tests: Split drm_framebuffer_create_test into parameterized tests	2022-09-14 13:53:33 -03:00
drm_mm_test.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
drm_plane_helper_test.c	drm/tests: Change "igt_" prefix to "drm_test_"	2022-09-14 13:53:33 -03:00
drm_rect_test.c	drm/tests: Change "igt_" prefix to "drm_test_"	2022-09-14 13:53:33 -03:00
Makefile	drm: selftest: convert drm_mm selftest to KUnit	2022-07-11 14:00:05 +02:00