linux/tools/lib
Steven Rostedt dd4b0cc442 tools lib traceevent: Do not reassign parg after collapse_tree()
[ Upstream commit 106b816cb4 ]

At the end of process_filter(), collapse_tree() was changed to update
the parg parameter, but the reassignment after the call wasn't removed.

What happens is that the "current_op" gets modified and freed and parg
is assigned to the new allocated argument. But after the call to
collapse_tree(), parg is assigned again to the just freed "current_op",
and this causes the tool to crash.

The current_op variable must also be assigned to NULL in case of error,
otherwise it will cause it to be free()ed twice.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org # 3.14+
Fixes: 42d6194d13 ("tools lib traceevent: Refactor process_filter()")
Link: http://lkml.kernel.org/r/20160511150936.678c18a1@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
History 2016-05-17 22:05:21 -04:00
..
api tools lib fd array: Allow associating an integer cookie with each entry 2014-09-25 16:46:55 -03:00
lockdep tools/liblockdep: Account for bitfield changes in lockdeps lock_acquire 2014-07-07 12:20:16 -04:00
symbol tools lib symbol: Start carving out symbol parsing routines from perf 2013-12-13 10:30:20 -03:00
traceevent tools lib traceevent: Do not reassign parg after collapse_tree() 2016-05-17 22:05:21 -04:00