kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-18 19:12:56 +00:00
Code Issues Releases Packages Activity
linux/fs/ceph
History
Luis Henriques 3c42d664ec ceph: fix memory leak in __ceph_setxattr() 
commit eeca958dce upstream.

The ceph_inode_xattr needs to be released when removing an xattr.  Easily
reproducible running the 'generic/020' test from xfstests or simply by
doing:

  attr -s attr0 -V 0 /mnt/test && attr -r attr0 /mnt/test

While there, also fix the error path.

Here's the kmemleak splat:

unreferenced object 0xffff88001f86fbc0 (size 64):
  comm "attr", pid 244, jiffies 4294904246 (age 98.464s)
  hex dump (first 32 bytes):
    40 fa 86 1f 00 88 ff ff 80 32 38 1f 00 88 ff ff  @........28.....
    00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de  ................
  backtrace:
    [<ffffffff81560199>] kmemleak_alloc+0x49/0xa0
    [<ffffffff810f3e5b>] kmem_cache_alloc+0x9b/0xf0
    [<ffffffff812b157e>] __ceph_setxattr+0x17e/0x820
    [<ffffffff812b1c57>] ceph_set_xattr_handler+0x37/0x40
    [<ffffffff8111fb4b>] __vfs_removexattr+0x4b/0x60
    [<ffffffff8111fd37>] vfs_removexattr+0x77/0xd0
    [<ffffffff8111fdd1>] removexattr+0x41/0x60
    [<ffffffff8111fe65>] path_removexattr+0x75/0xa0
    [<ffffffff81120aeb>] SyS_lremovexattr+0xb/0x10
    [<ffffffff81564b20>] entry_SYSCALL_64_fastpath+0x13/0x94
    [<ffffffffffffffff>] 0xffffffffffffffff

Signed-off-by: Luis Henriques <lhenriques@suse.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2017-08-26 02:14:46 +01:00
..
acl.c posix_acl: Clear SGID bit when setting file permissions 2016-11-20 01:17:38 +00:00
addr.c ceph: do_sync is never initialized 2015-01-15 10:44:10 +00:00
cache.c ceph: fscache: Wait for completion of object initialization 2014-04-03 10:33:53 +08:00
cache.h ceph: fscache: add an interface to synchronize object store limit 2014-04-03 10:33:53 +08:00
caps.c mds: check cap ID when handling cap export message 2014-06-06 09:29:55 +08:00
ceph_frag.c ceph: factor out libceph from Ceph file system 2010-10-20 15:37:28 -07:00
debugfs.c fs/ceph/debugfs.c: replace seq_printf by seq_puts 2014-06-06 16:08:06 -07:00
dir.c move d_rcu from overlapping d_child to overlapping d_alias 2015-01-15 10:44:58 +00:00
export.c ceph: ceph_get_parent() can be static 2014-06-06 09:29:50 +08:00
file.c ceph: Correctly return NXIO errors from ceph_llseek 2016-11-20 01:16:59 +00:00
inode.c ceph: fix recursion between ceph_set_acl() and __ceph_setattr() 2017-07-18 18:40:39 +01:00
ioctl.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client 2014-05-05 15:17:02 -07:00
ioctl.h ceph: fully initialize new layout 2012-05-16 14:28:27 -05:00
Kconfig ceph: add acl for cephfs 2013-12-31 20:32:01 +02:00
locks.c locks: ensure that fl_owner is always initialized properly in flock and lease codepaths 2014-06-02 08:09:29 -04:00
Makefile ceph: add acl for cephfs 2013-12-31 20:32:01 +02:00
mds_client.c ceph: fix bad endianness handling in parse_reply_info_extra 2017-03-16 02:27:01 +00:00
mds_client.h ceph: include time stamp in every MDS request 2014-06-06 09:30:00 +08:00
mdsmap.c fs/ceph: replace pr_warning by pr_warn 2014-06-06 16:08:06 -07:00
snap.c ceph: introduce global empty snap context 2015-02-17 15:12:01 +00:00
strings.c ceph: add get_name() NFS export callback 2014-04-03 10:33:53 +08:00
super.c fs: create and use seq_show_option for escaping 2015-09-29 16:44:47 +01:00
super.h ceph: introduce global empty snap context 2015-02-17 15:12:01 +00:00
xattr.c ceph: fix memory leak in __ceph_setxattr() 2017-08-26 02:14:46 +01:00