Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Kenta Akagi 1235bad700 selftests: mptcp: connect: fix build regression caused by backport ... Since v6.1.154, mptcp selftests have failed to build with the following errors: mptcp_connect.c: In function ‘main_loop_s’: mptcp_connect.c:1040:59: error: ‘winfo’ undeclared (first use in this function) 1040 | err = copyfd_io(fd, remotesock, 1, true, &winfo); | ^~~~~ mptcp_connect.c:1040:59: note: each undeclared identifier is reported only once for each function it appears in mptcp_connect.c:1040:23: error: too many arguments to function ‘copyfd_io’; expected 4, have 5 1040 | err = copyfd_io(fd, remotesock, 1, true, &winfo); | ^~~~~~~~~ ~~~~~~ mptcp_connect.c:845:12: note: declared here 845 | static int copyfd_io(int infd, int peerfd, int outfd, bool close_peerfd) | ^~~~~~~~~ This is caused by commit ff160500c4 ("selftests: mptcp: connect: catch IO errors on listen side"), a backport of upstream 14e22b43df, which attempts to use the undeclared variable 'winfo' and passes too many arguments to copyfd_io(). Both the winfo variable and the updated copyfd_io() function were introduced in upstream commit ca7ae89160 ("selftests: mptcp: mptfo Initiator/Listener"), which is not present in v6.1.y. The goal of the backport is to stop on errors from copyfd_io. Therefore, the backport does not depend on the changes in upstream commit ca7ae89160 ("selftests: mptcp: mptfo Initiator/Listener"). This commit simply removes ', &winfo' to fix a build failure. Fixes: ff160500c4 ("selftests: mptcp: connect: catch IO errors on listen side") Signed-off-by: Kenta Akagi <k@mgml.me> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2025-10-15 11:56:20 +02:00
..
crypto/chacha20-s390	tools/testing/crypto: Use vzalloc instead of vmalloc+memset	2022-07-05 14:46:36 +02:00
cxl	cxl/test: Add missing vmalloc.h for tools/testing/cxl/test/mem.c	2024-06-21 14:35:45 +02:00
fault-injection	docs: fault-injection: convert docs to ReST and rename to *.rst	2019-06-14 14:21:07 -06:00
ktest	ktest.pl: Prevent recursion of default variable options	2025-08-28 16:25:55 +02:00
kunit	kunit: tool: Use qboot on QEMU x86_64	2025-06-04 14:40:14 +02:00
memblock	memblock tests: fix warning ‘struct seq_file’ declared inside parameter list	2023-10-06 14:56:56 +02:00
nvdimm	ndtest: Cleanup all of blk namespace specific code	2022-07-12 17:57:55 -07:00
radix-tree	test suite: use %zu to print size_t	2025-04-25 10:43:50 +02:00
scatterlist	tools/testing/scatterlist: add missing defines	2022-01-30 09:56:58 +02:00
selftests	selftests: mptcp: connect: fix build regression caused by backport	2025-10-15 11:56:20 +02:00
vsock	vsock_test: POLLIN + SO_RCVLOWAT test	2022-08-23 10:43:12 +02:00