Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Stanislav Fomichev 0a13c1e0a4 net: revert to lockless TC_SETUP_BLOCK and TC_SETUP_FT ... There is a couple of places from which we can arrive to ndo_setup_tc with TC_SETUP_BLOCK/TC_SETUP_FT: - netlink - netlink notifier - netdev notifier Locking netdev too deep in this call chain seems to be problematic (especially assuming some/all of the call_netdevice_notifiers NETDEV_UNREGISTER) might soon be running with the instance lock). Revert to lockless ndo_setup_tc for TC_SETUP_BLOCK/TC_SETUP_FT. NFT framework already takes care of most of the locking. Document the assumptions. ndo_setup_tc TC_SETUP_BLOCK nft_block_offload_cmd nft_chain_offload_cmd nft_flow_block_chain nft_flow_offload_chain nft_flow_rule_offload_abort nft_flow_rule_offload_commit nft_flow_rule_offload_commit nf_tables_commit nfnetlink_rcv_batch nfnetlink_rcv_skb_batch nfnetlink_rcv nft_offload_netdev_event NETDEV_UNREGISTER notifier ndo_setup_tc TC_SETUP_FT nf_flow_table_offload_cmd nf_flow_table_offload_setup nft_unregister_flowtable_hook nft_register_flowtable_net_hooks nft_flowtable_update nf_tables_newflowtable nfnetlink_rcv_batch (.call NFNL_CB_BATCH) nft_flowtable_update nf_tables_newflowtable nft_flowtable_event nf_tables_flowtable_event NETDEV_UNREGISTER notifier __nft_unregister_flowtable_net_hooks nft_unregister_flowtable_net_hooks nf_tables_commit nfnetlink_rcv_batch (.call NFNL_CB_BATCH) __nf_tables_abort nf_tables_abort nfnetlink_rcv_batch __nft_release_hook __nft_release_hooks nf_tables_pre_exit_net -> module unload nft_rcv_nl_event netlink_register_notifier (oh boy) nft_register_flowtable_net_hooks nft_flowtable_update nf_tables_newflowtable nf_tables_newflowtable Fixes: c4f0f30b42 ("net: hold netdev instance lock during nft ndo_setup_tc") Signed-off-by: Stanislav Fomichev <sdf@fomichev.me> Reported-by: syzbot+0afb4bcf91e5a1afdcad@syzkaller.appspotmail.com Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20250308044726.1193222-1-sdf@fomichev.me Signed-off-by: Jakub Kicinski <kuba@kernel.org>		History 2025-03-12 13:02:00 -07:00
..
acpi	LoongArch changes for v6.14	2025-01-28 08:52:01 -08:00
asm-generic	arm64 fixes for -rc5	2025-03-01 13:44:51 -08:00
clocksource	KVM/arm64 updates for 6.14	2025-01-28 09:01:36 -08:00
crypto	crypto: skcipher - document skcipher_walk_done() and rename some vars	2025-01-14 11:38:32 +08:00
cxl	cxl/events: Update Memory Module Event Record to CXL spec rev 3.1	2025-01-13 09:33:21 -07:00
drm	drm: Fix DSC BPP increment decoding	2025-02-13 10:20:30 +02:00
dt-bindings	dt-bindings: clock: qcom: Add CAMCC clocks for QCS8300	2025-02-02 20:59:04 -06:00
hyperv	hyperv: Add new Hyper-V headers in include/hyperv	2025-01-10 00:54:20 +00:00
keys	keys: drop shadowing dead prototype	2025-01-21 11:25:23 +02:00
kunit	linux_kselftest-kunit-6.14-rc1	2025-01-22 12:32:39 -08:00
kvm	Merge branch kvm-arm64/pkvm-memshare-declutter into kvmarm-master/next	2025-01-17 11:05:18 +00:00
linux	net: revert to lockless TC_SETUP_BLOCK and TC_SETUP_FT	2025-03-12 13:02:00 -07:00
math-emu	powerpc/math-emu: Remove -w build flag and fix warnings	2022-09-05 17:28:25 +10:00
media	media: cec: include linux/debugfs.h and linux/seq_file.h where needed	2025-01-07 12:21:38 +01:00
memory	memory: renesas-rpc-if: Remove Runtime PM wrappers	2023-01-23 11:48:00 +01:00
misc	cxl: fix typo in comment	2022-11-24 23:12:19 +11:00
net	net: move misc netdev_lock flavors to a separate header	2025-03-08 09:06:50 -08:00
pcmcia	ARM: pxa/sa1100: move I/O space to PCI_IOBASE	2022-05-07 22:56:17 +02:00
ras	mm/memory-failure: remove obsolete MF_MSG_DIFFERENT_COMPOUND	2024-07-12 15:52:22 -07:00
rdma	RDMA/core: Support link status events dispatching	2024-12-24 05:22:18 -05:00
rv	rv: Reset per-task monitors also for idle tasks	2025-01-23 12:16:04 -05:00
scsi	Driver core and debugfs updates	2025-01-28 12:25:12 -08:00
soc	soc: driver updates for 6.14	2025-01-24 14:56:59 -08:00
sound	ASoC: cs35l56: Prevent races when soft-resetting using SPI control	2025-02-25 15:06:58 +00:00
target	scsi: target: iscsi: switch to using the crc32c library	2024-12-01 17:23:02 -08:00
trace	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2025-02-27 10:20:58 -08:00
uapi	First 6.15 material:	2025-03-04 08:50:42 -08:00
ufs	scsi: ufs: core: Fix use-after free in init error and remove paths	2025-02-03 17:20:01 -05:00
vdso	vdso: Correct typo in PAGE_SHIFT comment	2025-01-15 11:07:08 +01:00
video	- Improved handling of LCD power states and interactions with the fbdev subsystem.	2024-11-22 16:29:57 -08:00
xen	xen: Remove dependency between pciback and privcmd	2024-10-18 11:59:04 +02:00