kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-26 19:14:18 +00:00
Code Issues Releases Packages Activity
linux/drivers/i3c/master
History
Pei Xiao 60d2fb033a i3c: dw: Fix use-after-free in dw_i3c_master driver due to race condition 
[ Upstream commit b75439c945 ]

In dw_i3c_common_probe, &master->hj_work is bound with
dw_i3c_hj_work. And dw_i3c_master_irq_handler can call
dw_i3c_master_irq_handle_ibis function to start the work.

If we remove the module which will call dw_i3c_common_remove to
make cleanup, it will free master->base through i3c_master_unregister
while the work mentioned above will be used. The sequence of operations
that may lead to a UAF bug is as follows:

CPU0                                      CPU1

                                     | dw_i3c_hj_work
dw_i3c_common_remove                 |
i3c_master_unregister(&master->base) |
device_unregister(&master->dev)      |
device_release                       |
//free master->base                  |
                                     | i3c_master_do_daa(&master->base)
                                     | //use master->base

Fix it by ensuring that the work is canceled before proceeding with
the cleanup in dw_i3c_common_remove.

Fixes: 1dd728f5d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Link: https://lore.kernel.org/r/bfc49c9527be5b513e7ceafeba314ca40a5be4bc.1732703537.git.xiaopei01@kylinos.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2025-02-08 09:52:22 +01:00
..
mipi-i3c-hci i3c: mipi-i3c-hci: Mask ring interrupts before ring stop request 2024-12-14 20:00:13 +01:00
ast2600-i3c-master.c i3c: Explicitly include correct DT includes 2023-07-27 23:23:41 +02:00
dw-i3c-master.c i3c: dw: Fix use-after-free in dw_i3c_master driver due to race condition 2025-02-08 09:52:22 +01:00
dw-i3c-master.h i3c: dw: Add hot-join support. 2025-02-08 09:52:21 +01:00
i3c-master-cdns.c i3c: master: cdns: Fix use after free vulnerability in cdns_i3c_master Driver Due to Race Condition 2024-10-17 15:24:17 +02:00
Kconfig i3c: ast2600: Add AST2600 platform-specific driver 2023-04-28 08:19:01 +02:00
Makefile i3c: ast2600: Add AST2600 platform-specific driver 2023-04-28 08:19:01 +02:00
svc-i3c-master.c i3c: master: svc: fix possible assignment of the same address to two devices 2024-12-14 20:00:23 +01:00