kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-28 20:03:05 +00:00
Code Issues Releases Packages Activity
linux/drivers/pinctrl/samsung
History
Javier Carrasco 0228e5a667 pinctrl: samsung: fix fwnode refcount cleanup if platform_get_irq_optional() fails 
commit 459915f555 upstream.

Commit 50ebd19e35 ("pinctrl: samsung: drop pin banks references on
error paths") fixed the pin bank references on the error paths of the
probe function, but there is still an error path where this is not done.

If samsung_pinctrl_get_soc_data() does not fail, the child references
will have acquired, and they will need to be released in the error path
of platform_get_irq_optional(), as it is done in the following error
paths within the probe function.

Replace the direct return in the error path with a goto instruction to
the cleanup function.

Cc: stable@vger.kernel.org
Fixes: a382d568f1 ("pinctrl: samsung: Use platform_get_irq_optional() to get the interrupt")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20241106-samsung-pinctrl-put-v1-1-de854e26dd03@gmail.com
[krzysztof: change Fixes SHA to point to commit introducing the return
 leading to OF node leak]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2025-02-17 09:40:40 +01:00
..
Kconfig pinctrl: remove s3c24xx driver 2023-01-16 09:26:06 +01:00
Makefile pinctrl: remove s3c24xx driver 2023-01-16 09:26:06 +01:00
pinctrl-exynos-arm.c pinctrl: samsung: fix leaked of_node references 2019-04-23 10:59:47 +02:00
pinctrl-exynos-arm64.c pinctrl: samsung: staticize fsd_pin_ctrl 2022-04-04 18:58:26 +02:00
pinctrl-exynos.c pinctrl: samsung: do not use bindings header with constants 2022-06-28 15:55:20 +02:00
pinctrl-exynos.h pinctrl: samsung: do not use bindings header with constants 2022-06-28 15:55:20 +02:00
pinctrl-s3c64xx.c pinctrl: samsung: Switch to use for_each_gpiochip_node() helper 2022-04-14 21:44:58 +03:00
pinctrl-samsung.c pinctrl: samsung: fix fwnode refcount cleanup if platform_get_irq_optional() fails 2025-02-17 09:40:40 +01:00
pinctrl-samsung.h pinctrl: samsung: do not use bindings header with constants 2022-06-28 15:55:20 +02:00