kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-24 19:10:26 +00:00
Code Issues Releases Packages Activity
linux/drivers/tee/optee
History
Jens Wiklander 5f28563f0c optee: ffa: fix sleep in atomic context 
commit 312d02adb9 upstream.

The OP-TEE driver registers the function notif_callback() for FF-A
notifications. However, this function is called in an atomic context
leading to errors like this when processing asynchronous notifications:

 | BUG: sleeping function called from invalid context at kernel/locking/mutex.c:258
 | in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 9, name: kworker/0:0
 | preempt_count: 1, expected: 0
 | RCU nest depth: 0, expected: 0
 | CPU: 0 UID: 0 PID: 9 Comm: kworker/0:0 Not tainted 6.14.0-00019-g657536ebe0aa #13
 | Hardware name: linux,dummy-virt (DT)
 | Workqueue: ffa_pcpu_irq_notification notif_pcpu_irq_work_fn
 | Call trace:
 |  show_stack+0x18/0x24 (C)
 |  dump_stack_lvl+0x78/0x90
 |  dump_stack+0x18/0x24
 |  __might_resched+0x114/0x170
 |  __might_sleep+0x48/0x98
 |  mutex_lock+0x24/0x80
 |  optee_get_msg_arg+0x7c/0x21c
 |  simple_call_with_arg+0x50/0xc0
 |  optee_do_bottom_half+0x14/0x20
 |  notif_callback+0x3c/0x48
 |  handle_notif_callbacks+0x9c/0xe0
 |  notif_get_and_handle+0x40/0x88
 |  generic_exec_single+0x80/0xc0
 |  smp_call_function_single+0xfc/0x1a0
 |  notif_pcpu_irq_work_fn+0x2c/0x38
 |  process_one_work+0x14c/0x2b4
 |  worker_thread+0x2e4/0x3e0
 |  kthread+0x13c/0x210
 |  ret_from_fork+0x10/0x20

Fix this by adding work queue to process the notification in a
non-atomic context.

Fixes: d0476a59de ("optee: ffa_abi: add asynchronous notifications")
Cc: stable@vger.kernel.org
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20250602120452.2507084-1-jens.wiklander@linaro.org
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2025-07-10 16:05:12 +02:00
..
call.c tee: Refactor TEE subsystem header files 2024-04-03 09:19:31 +02:00
core.c optee: probe RPMB device using RPMB subsystem 2024-08-26 13:16:20 +02:00
device.c optee: probe RPMB device using RPMB subsystem 2024-08-26 13:16:20 +02:00
ffa_abi.c optee: ffa: fix sleep in atomic context 2025-07-10 16:05:12 +02:00
Kconfig optee: add RPMB dependency 2024-09-03 14:34:45 +02:00
Makefile optee: separate notification functions 2021-11-17 14:08:56 +01:00
notif.c optee: add timeout parameter for notification wait 2024-06-27 16:44:37 +02:00
optee_ffa.h optee: probe RPMB device using RPMB subsystem 2024-08-26 13:16:20 +02:00
optee_msg.h tee: optee: Add SMC for loading OP-TEE image 2023-04-03 08:57:49 +02:00
optee_private.h optee: ffa: fix sleep in atomic context 2025-07-10 16:05:12 +02:00
optee_rpc_cmd.h optee: probe RPMB device using RPMB subsystem 2024-08-26 13:16:20 +02:00
optee_smc.h optee: probe RPMB device using RPMB subsystem 2024-08-26 13:16:20 +02:00
optee_trace.h tee: optee: add invoke_fn tracepoints 2021-03-15 12:04:01 +01:00
rpc.c optee: Fix a NULL vs IS_ERR() check 2024-09-09 12:22:06 +02:00
smc_abi.c optee: probe RPMB device using RPMB subsystem 2024-08-26 13:16:20 +02:00
supp.c tee: optee: Fix supplicant wait loop 2025-02-27 04:30:21 -08:00