Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Pei Xiao 60d2fb033a i3c: dw: Fix use-after-free in dw_i3c_master driver due to race condition ... [ Upstream commit b75439c945 ] In dw_i3c_common_probe, &master->hj_work is bound with dw_i3c_hj_work. And dw_i3c_master_irq_handler can call dw_i3c_master_irq_handle_ibis function to start the work. If we remove the module which will call dw_i3c_common_remove to make cleanup, it will free master->base through i3c_master_unregister while the work mentioned above will be used. The sequence of operations that may lead to a UAF bug is as follows: CPU0 CPU1 | dw_i3c_hj_work dw_i3c_common_remove | i3c_master_unregister(&master->base) | device_unregister(&master->dev) | device_release | //free master->base | | i3c_master_do_daa(&master->base) | //use master->base Fix it by ensuring that the work is canceled before proceeding with the cleanup in dw_i3c_common_remove. Fixes: 1dd728f5d4 ("i3c: master: Add driver for Synopsys DesignWare IP") Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> Link: https://lore.kernel.org/r/bfc49c9527be5b513e7ceafeba314ca40a5be4bc.1732703537.git.xiaopei01@kylinos.cn Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2025-02-08 09:52:22 +01:00
..
master	i3c: dw: Fix use-after-free in dw_i3c_master driver due to race condition	2025-02-08 09:52:22 +01:00
device.c	driver core: make struct device_type.uevent() take a const *	2023-01-27 13:45:36 +01:00
internals.h	i3c: export SETDASA method	2022-12-11 21:25:58 +01:00
Kconfig	i3c: Add core I3C infrastructure	2018-11-12 10:33:49 +01:00
Makefile	i3c: Add core I3C infrastructure	2018-11-12 10:33:49 +01:00
master.c	i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin	2024-12-14 20:00:23 +01:00