Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Yan Zhai 1b87044469 udp: gso: do not drop small packets when PMTU reduces ... [ Upstream commit 235174b2be ] Commit 4094871db1 ("udp: only do GSO if # of segs > 1") avoided GSO for small packets. But the kernel currently dismisses GSO requests only after checking MTU/PMTU on gso_size. This means any packets, regardless of their payload sizes, could be dropped when PMTU becomes smaller than requested gso_size. We encountered this issue in production and it caused a reliability problem that new QUIC connection cannot be established before PMTU cache expired, while non GSO sockets still worked fine at the same time. Ideally, do not check any GSO related constraints when payload size is smaller than requested gso_size, and return EMSGSIZE instead of EINVAL on MTU/PMTU check failure to be more specific on the error cause. Fixes: 4094871db1 ("udp: only do GSO if # of segs > 1") Signed-off-by: Yan Zhai <yan@cloudflare.com> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2025-02-21 13:49:36 +01:00
..
crypto/chacha20-s390	tools/testing/crypto: Use vzalloc instead of vmalloc+memset	2022-07-05 14:46:36 +02:00
cxl	cxl/test: Add missing vmalloc.h for tools/testing/cxl/test/mem.c	2024-06-21 14:35:45 +02:00
fault-injection	docs: fault-injection: convert docs to ReST and rename to *.rst	2019-06-14 14:21:07 -06:00
ktest	ktest.pl: Check kernelrelease return in get_version	2025-02-21 13:49:26 +01:00
kunit	kunit: tool: Don't download risc-v opensbi firmware with wget	2022-10-07 10:16:28 -06:00
memblock	memblock tests: fix warning ‘struct seq_file’ declared inside parameter list	2023-10-06 14:56:56 +02:00
nvdimm	ndtest: Cleanup all of blk namespace specific code	2022-07-12 17:57:55 -07:00
radix-tree	XArray: Do not return sibling entries from xa_load()	2023-09-13 09:43:00 +02:00
scatterlist	tools/testing/scatterlist: add missing defines	2022-01-30 09:56:58 +02:00
selftests	udp: gso: do not drop small packets when PMTU reduces	2025-02-21 13:49:36 +01:00
vsock	vsock_test: POLLIN + SO_RCVLOWAT test	2022-08-23 10:43:12 +02:00