linux/drivers/phy
Chenyuan Yang 0b979a409e phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug
[ Upstream commit d14402a38c ]

The qmp_usb_iomap() helper function currently returns the raw result of
devm_ioremap() for non-exclusive mappings. Since devm_ioremap() may return
a NULL pointer and the caller only checks error pointers with IS_ERR(),
NULL could bypass the check and lead to an invalid dereference.

Fix the issue by checking if devm_ioremap() returns NULL. When it does,
qmp_usb_iomap() now returns an error pointer via IOMEM_ERR_PTR(-ENOMEM),
ensuring safe and consistent error handling.

Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Fixes: a5d6b1ac56 ("phy: qcom-qmp-usb: fix memleak on probe deferral")
CC: Johan Hovold <johan@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250414125050.2118619-1-chenyuan0y@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2025-06-27 11:07:16 +01:00
..
allwinner phy: sun4i-usb: Add support for the H616 USB PHY 2023-01-04 11:28:56 +01:00
amlogic phy: amlogic: phy-meson-g12a-mipi-dphy-analog: fix CNTL2_DIF_TX_CTL0 value 2023-06-09 10:33:58 +02:00
broadcom phy: usb: Toggle the PHY power during init 2025-01-02 10:30:50 +01:00
cadence phy: cadence-torrent: Check return value on register read 2024-08-03 08:49:47 +02:00
freescale phy: freescale: imx8m-pcie: Add one missing error return 2025-05-02 07:47:10 +02:00
hisilicon phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe() 2023-08-03 10:23:59 +02:00
ingenic phy: ingenic: Fix a typo in ingenic_usb_phy_probe() 2021-03-30 23:35:17 +05:30
intel phy: intel: Use dev_err_probe() to simplify code 2022-09-24 12:34:56 +05:30
lantiq phy: lantiq: rcu-usb2: wait after clock enable 2021-01-13 19:29:03 +05:30
marvell phy: marvell: a3700-comphy: Fix hardcoded array size 2024-05-02 16:29:31 +02:00
mediatek phy: phy-mtk-dp: Fix an error code in probe() 2023-08-03 10:23:56 +02:00
microchip phy-for-6.1 2022-10-07 16:03:01 -07:00
motorola phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins 2023-10-25 12:03:16 +02:00
mscc treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
qualcomm phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug 2025-06-27 11:07:16 +01:00
ralink phy: ralink: mt7621-pci: add sentinel to quirks table 2022-11-05 13:01:25 +05:30
renesas phy: renesas: rcar-gen3-usb2: Assert PLL reset on PHY power off 2025-06-04 14:40:01 +02:00
rockchip phy: rockchip: naneng-combphy: compatible reset with old DT 2025-03-07 16:56:47 +01:00
samsung phy: exynos5-usbdrd: fix MPLL_MULTIPLIER and SSC_REFCLKSEL masks in refclk 2025-03-07 16:56:50 +01:00
socionext phy: uniphier-usb3ss: fix unintended writing zeros to PHY register 2021-12-24 10:06:38 +05:30
st phy: st: miphy28lp: use _poll_timeout functions for waits 2023-05-24 17:32:41 +01:00
sunplus phy: usb: sunplus: Fix potential null-ptr-deref in sp_usb_phy_probe() 2023-02-01 08:34:09 +01:00
tegra phy: Fix error handling in tegra_xusb_port_init 2025-05-22 14:10:06 +02:00
ti phy: ti: tusb1210: Resolve charger-det crash if charger psy is unregistered 2024-05-02 16:29:31 +02:00
xilinx phy: zynqmp: Take the phy mutex in xlate 2024-09-12 11:10:22 +02:00
Kconfig phy: usb: Add USB2.0 phy driver for Sunplus SP7021 2022-09-02 21:01:24 +05:30
Makefile phy: usb: Add USB2.0 phy driver for Sunplus SP7021 2022-09-02 21:01:24 +05:30
phy-can-transceiver.c phy: phy-can-transceiver: Skip warning if no "max-bitrate" 2023-02-01 08:34:25 +01:00
phy-core-mipi-dphy.c phy: dphy: Correct lpx parameter and its derivatives(ta_{get,go,sure}) 2022-02-25 14:14:06 +05:30
phy-core.c phy: core: don't require set_mode() callback for phy_get_mode() to work 2025-06-04 14:40:14 +02:00
phy-lgm-usb.c phy: Add USB3 PHY support for Intel LGM SoC 2020-09-11 17:12:49 +05:30
phy-lpc18xx-usb-otg.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
phy-pistachio-usb.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 422 2019-06-05 17:37:15 +02:00
phy-xgene.c phy: phy-xgene.c: Fix alignment of comment 2021-05-31 14:08:55 +05:30