Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Oliver Hartkopp bb208f144c can: fix handling of unmodifiable configuration options ... As described in 'can: m_can: tag current CAN FD controllers as non-ISO' (6cfda7fbeb) it is possible to define fixed configuration options by setting the according bit in 'ctrlmode' and clear it in 'ctrlmode_supported'. This leads to the incovenience that the fixed configuration bits can not be passed by netlink even when they have the correct values (e.g. non-ISO, FD). This patch fixes that issue and not only allows fixed set bit values to be set again but now requires(!) to provide these fixed values at configuration time. A valid CAN FD configuration consists of a nominal/arbitration bittiming, a data bittiming and a control mode with CAN_CTRLMODE_FD set - which is now enforced by a new can_validate() function. This fix additionally removed the inconsistency that was prohibiting the support of 'CANFD-only' controller drivers, like the RCar CAN FD. For this reason a new helper can_set_static_ctrlmode() has been introduced to provide a proper interface to handle static enabled CAN controller options. Reported-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net> Reviewed-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> Cc: <stable@vger.kernel.org> # >= 3.18 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>		History 2016-05-09 11:07:28 +02:00
..
platform	can: unify identifiers to ensure unique include processing	2014-05-19 09:38:24 +02:00
core.h	can: unify identifiers to ensure unique include processing	2014-05-19 09:38:24 +02:00
dev.h	can: fix handling of unmodifiable configuration options	2016-05-09 11:07:28 +02:00
led.h	can: headers: make header files self contained	2015-09-21 08:38:22 +02:00
skb.h	can: replace timestamp as unique skb attribute	2015-07-12 21:13:22 +02:00