Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

felix cc2e7ebbeb SUNRPC: Fix RPC client cleaned up the freed pipefs dentries ... [ Upstream commit bfca5fb4e9 ] RPC client pipefs dentries cleanup is in separated rpc_remove_pipedir() workqueue,which takes care about pipefs superblock locking. In some special scenarios, when kernel frees the pipefs sb of the current client and immediately alloctes a new pipefs sb, rpc_remove_pipedir function would misjudge the existence of pipefs sb which is not the one it used to hold. As a result, the rpc_remove_pipedir would clean the released freed pipefs dentries. To fix this issue, rpc_remove_pipedir should check whether the current pipefs sb is consistent with the original pipefs sb. This error can be catched by KASAN: ========================================================= [ 250.497700] BUG: KASAN: slab-use-after-free in dget_parent+0x195/0x200 [ 250.498315] Read of size 4 at addr ffff88800a2ab804 by task kworker/0:18/106503 [ 250.500549] Workqueue: events rpc_free_client_work [ 250.501001] Call Trace: [ 250.502880] kasan_report+0xb6/0xf0 [ 250.503209] ? dget_parent+0x195/0x200 [ 250.503561] dget_parent+0x195/0x200 [ 250.503897] ? __pfx_rpc_clntdir_depopulate+0x10/0x10 [ 250.504384] rpc_rmdir_depopulate+0x1b/0x90 [ 250.504781] rpc_remove_client_dir+0xf5/0x150 [ 250.505195] rpc_free_client_work+0xe4/0x230 [ 250.505598] process_one_work+0x8ee/0x13b0 ... [ 22.039056] Allocated by task 244: [ 22.039390] kasan_save_stack+0x22/0x50 [ 22.039758] kasan_set_track+0x25/0x30 [ 22.040109] __kasan_slab_alloc+0x59/0x70 [ 22.040487] kmem_cache_alloc_lru+0xf0/0x240 [ 22.040889] __d_alloc+0x31/0x8e0 [ 22.041207] d_alloc+0x44/0x1f0 [ 22.041514] __rpc_lookup_create_exclusive+0x11c/0x140 [ 22.041987] rpc_mkdir_populate.constprop.0+0x5f/0x110 [ 22.042459] rpc_create_client_dir+0x34/0x150 [ 22.042874] rpc_setup_pipedir_sb+0x102/0x1c0 [ 22.043284] rpc_client_register+0x136/0x4e0 [ 22.043689] rpc_new_client+0x911/0x1020 [ 22.044057] rpc_create_xprt+0xcb/0x370 [ 22.044417] rpc_create+0x36b/0x6c0 ... [ 22.049524] Freed by task 0: [ 22.049803] kasan_save_stack+0x22/0x50 [ 22.050165] kasan_set_track+0x25/0x30 [ 22.050520] kasan_save_free_info+0x2b/0x50 [ 22.050921] __kasan_slab_free+0x10e/0x1a0 [ 22.051306] kmem_cache_free+0xa5/0x390 [ 22.051667] rcu_core+0x62c/0x1930 [ 22.051995] __do_softirq+0x165/0x52a [ 22.052347] [ 22.052503] Last potentially related work creation: [ 22.052952] kasan_save_stack+0x22/0x50 [ 22.053313] __kasan_record_aux_stack+0x8e/0xa0 [ 22.053739] __call_rcu_common.constprop.0+0x6b/0x8b0 [ 22.054209] dentry_free+0xb2/0x140 [ 22.054540] __dentry_kill+0x3be/0x540 [ 22.054900] shrink_dentry_list+0x199/0x510 [ 22.055293] shrink_dcache_parent+0x190/0x240 [ 22.055703] do_one_tree+0x11/0x40 [ 22.056028] shrink_dcache_for_umount+0x61/0x140 [ 22.056461] generic_shutdown_super+0x70/0x590 [ 22.056879] kill_anon_super+0x3a/0x60 [ 22.057234] rpc_kill_sb+0x121/0x200 Fixes: 0157d021d2 ("SUNRPC: handle RPC client pipefs dentries by network namespace aware routines") Signed-off-by: felix <fuzhen5@huawei.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2023-11-28 17:19:49 +00:00
..
acpi	ACPI: APEI: Fix AER info corruption when error status data has multiple sections	2023-11-28 17:19:37 +00:00
asm-generic	hyperv-fixes for v6.6-rc6	2023-10-10 11:01:21 -07:00
clocksource	clocksource: hyper-v: Adjust hv_read_tsc_page_tsc() to avoid special casing U64_MAX	2023-06-05 21:11:07 +02:00
crypto	This update includes the following changes:	2023-08-29 11:23:29 -07:00
drm	drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos	2023-11-20 11:59:08 +01:00
dt-bindings	IOMMU Updates for Linux v6.6	2023-09-01 16:54:25 -07:00
keys	integrity: PowerVM support for loading third party code signing keys	2023-08-17 20:12:35 +00:00
kunit	- An extensive rework of kexec and crash Kconfig from Eric DeVolder	2023-08-29 14:53:51 -07:00
kvm	KVM: arm64: timers: Correctly handle TGE flip with CNTPOFF_EL2	2023-10-12 16:55:21 +01:00
linux	SUNRPC: Fix RPC client cleaned up the freed pipefs dentries	2023-11-28 17:19:49 +00:00
math-emu	powerpc/math-emu: Remove -w build flag and fix warnings	2022-09-05 17:28:25 +10:00
media	media: ipu-bridge: increase sensor_name size	2023-11-28 17:19:46 +00:00
memory	memory: renesas-rpc-if: Remove Runtime PM wrappers	2023-01-23 11:48:00 +01:00
misc	cxl: fix typo in comment	2022-11-24 23:12:19 +11:00
net	net: annotate data-races around sk->sk_dst_pending_confirm	2023-11-28 17:19:38 +00:00
pcmcia	ARM: pxa/sa1100: move I/O space to PCI_IOBASE	2022-05-07 22:56:17 +02:00
ras	mm, hwpoison: enable memory error handling on 1GB hugepage	2022-08-08 18:06:44 -07:00
rdma	RDMA Remove unused function declarations	2023-08-13 10:32:35 +03:00
rv	rv: Set variable 'da_mon_##name' to static	2023-09-01 21:00:00 -04:00
scsi	scsi: sd: Introduce manage_shutdown device flag	2023-10-27 10:00:19 +09:00
soc	firmware: tegra: Add suspend hook and reset BPMP IPC early on resume	2023-11-20 11:59:16 +01:00
sound	ASoC: SOF: Pass PCI SSID to machine driver	2023-11-28 17:19:42 +00:00
target	scsi: target: iscsi: Remove the unused netif_timeout attribute	2023-07-11 12:33:32 -04:00
trace	neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section	2023-10-18 11:16:43 +01:00
uapi	vsock: read from socket's error queue	2023-11-28 17:19:38 +00:00
ufs	Merge branch 'fixes' into misc	2023-09-02 08:25:19 +01:00
vdso	vdso/bits.h: Add BIT_ULL() for the sake of consistency	2023-01-31 14:42:10 +01:00
video	fbdev: uvesafb: Remove uvesafb_exec() prototype from include/video/uvesafb.h	2023-10-16 23:19:34 +02:00
xen	arm/xen: remove lazy mode related definitions	2023-09-19 07:04:49 +02:00