Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Vincent Mailhol f968a24cad can: treewide: remove can_change_mtu() ... can_change_mtu() became obsolete by commit 2304993860 ("can: populate the minimum and maximum MTU values"). Now that net_device->min_mtu and net_device->max_mtu are populated, all the checks are already done by dev_validate_mtu() in net/core/dev.c. Remove the net_device_ops->ndo_change_mtu() callback of all the physical interfaces, then remove can_change_mtu(). Only keep the vcan_change_mtu() and vxcan_change_mtu() because the virtual interfaces use their own different MTU logic. The only functional change this patch introduces is that now the user will be able to change the MTU even if the interface is up. This does not matter for Classical CAN and CAN FD because their MTU range is composed of only one value, respectively CAN_MTU and CANFD_MTU. For the upcoming CAN XL, the MTU will be configurable within the CANXL_MIN_MTU to CANXL_MAX_MTU range at any time, even if the interface is up. This is consistent with the other net protocols and does not contradict ISO 11898-1:2024 as having a modifiable MTU is a kernel extension. Signed-off-by: Vincent Mailhol <mailhol@kernel.org> Link: https://patch.msgid.link/20251003-remove-can_change_mtu-v1-1-337f8bc21181@kernel.org Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>		History 2025-10-17 09:57:13 +02:00
..
cc770.c	can: treewide: remove can_change_mtu()	2025-10-17 09:57:13 +02:00
cc770.h	can: drivers: fix spelling mistakes	2020-09-21 10:13:16 +02:00
cc770_isa.c	can: Switch back to struct platform_driver::remove()	2024-09-11 09:37:16 +02:00
cc770_platform.c	can: Switch back to struct platform_driver::remove()	2024-09-11 09:37:16 +02:00
Kconfig	can: {cc770,sja1000}_isa: allow building on x86_64	2024-11-04 17:46:06 +01:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00