Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Stanislav Fomichev 6dd132516f net: reorder dev_addr_sem lock ... Lockdep complains about circular lock in 1 -> 2 -> 3 (see below). Change the lock ordering to be: - rtnl_lock - dev_addr_sem - netdev_ops (only for lower devices!) - team_lock (or other per-upper device lock) 1. rtnl_lock -> netdev_ops -> dev_addr_sem rtnl_setlink rtnl_lock do_setlink IFLA_ADDRESS on lower netdev_ops dev_addr_sem 2. rtnl_lock -> team_lock -> netdev_ops rtnl_newlink rtnl_lock do_setlink IFLA_MASTER on lower do_set_master team_add_slave team_lock team_port_add dev_set_mtu netdev_ops 3. rtnl_lock -> dev_addr_sem -> team_lock rtnl_newlink rtnl_lock do_setlink IFLA_ADDRESS on upper dev_addr_sem netif_set_mac_address team_set_mac_address team_lock 4. rtnl_lock -> netdev_ops -> dev_addr_sem rtnl_lock dev_ifsioc dev_set_mac_address_user __tun_chr_ioctl rtnl_lock dev_set_mac_address_user tap_ioctl rtnl_lock dev_set_mac_address_user dev_set_mac_address_user netdev_lock_ops netif_set_mac_address_user dev_addr_sem v2: - move lock reorder to happen after kmalloc (Kuniyuki) Cc: Kohei Enju <enjuk@amazon.com> Fixes: df43d8bf10 ("net: replace dev_addr_sem with netdev instance lock") Signed-off-by: Stanislav Fomichev <sdf@fomichev.me> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://patch.msgid.link/20250312190513.1252045-3-sdf@fomichev.me Tested-by: Lei Yang <leiyang@redhat.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>		History 2025-03-19 18:52:00 +01:00
..
acpi	LoongArch changes for v6.14	2025-01-28 08:52:01 -08:00
asm-generic	arm64 fixes for -rc5	2025-03-01 13:44:51 -08:00
clocksource	KVM/arm64 updates for 6.14	2025-01-28 09:01:36 -08:00
crypto	crypto: skcipher - document skcipher_walk_done() and rename some vars	2025-01-14 11:38:32 +08:00
cxl	cxl/events: Update Memory Module Event Record to CXL spec rev 3.1	2025-01-13 09:33:21 -07:00
drm	drm: Fix DSC BPP increment decoding	2025-02-13 10:20:30 +02:00
dt-bindings	dt-bindings: clock: qcom: Add CAMCC clocks for QCS8300	2025-02-02 20:59:04 -06:00
hyperv	hyperv: Add new Hyper-V headers in include/hyperv	2025-01-10 00:54:20 +00:00
keys	keys: drop shadowing dead prototype	2025-01-21 11:25:23 +02:00
kunit	linux_kselftest-kunit-6.14-rc1	2025-01-22 12:32:39 -08:00
kvm	Merge branch kvm-arm64/pkvm-memshare-declutter into kvmarm-master/next	2025-01-17 11:05:18 +00:00
linux	net: reorder dev_addr_sem lock	2025-03-19 18:52:00 +01:00
math-emu	powerpc/math-emu: Remove -w build flag and fix warnings	2022-09-05 17:28:25 +10:00
media	media: cec: include linux/debugfs.h and linux/seq_file.h where needed	2025-01-07 12:21:38 +01:00
memory	memory: renesas-rpc-if: Remove Runtime PM wrappers	2023-01-23 11:48:00 +01:00
misc	cxl: fix typo in comment	2022-11-24 23:12:19 +11:00
net	tcp: cache RTAX_QUICKACK metric in a hot cache line	2025-03-18 13:44:59 +01:00
pcmcia	ARM: pxa/sa1100: move I/O space to PCI_IOBASE	2022-05-07 22:56:17 +02:00
ras	mm/memory-failure: remove obsolete MF_MSG_DIFFERENT_COMPOUND	2024-07-12 15:52:22 -07:00
rdma	RDMA/core: Support link status events dispatching	2024-12-24 05:22:18 -05:00
rv	rv: Reset per-task monitors also for idle tasks	2025-01-23 12:16:04 -05:00
scsi	Driver core and debugfs updates	2025-01-28 12:25:12 -08:00
soc	soc: driver updates for 6.14	2025-01-24 14:56:59 -08:00
sound	ASoC: cs35l56: Prevent races when soft-resetting using SPI control	2025-02-25 15:06:58 +00:00
target	scsi: target: iscsi: switch to using the crc32c library	2024-12-01 17:23:02 -08:00
trace	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2025-02-27 10:20:58 -08:00
uapi	This feature/cleanup patchset includes the following patches:	2025-03-18 12:10:20 +01:00
ufs	scsi: ufs: core: Fix use-after free in init error and remove paths	2025-02-03 17:20:01 -05:00
vdso	vdso: Correct typo in PAGE_SHIFT comment	2025-01-15 11:07:08 +01:00
video	- Improved handling of LCD power states and interactions with the fbdev subsystem.	2024-11-22 16:29:57 -08:00
xen	xen: Remove dependency between pciback and privcmd	2024-10-18 11:59:04 +02:00