linux/drivers/gpu/drm/exynos
Inki Dae b92ad44a1b drm/exynos: fix a wrong error checking
[ Upstream commit 8d1b780968 ]

Fix a wrong error checking in exynos_drm_dma.c module.

In the exynos_drm_register_dma function, both arm_iommu_create_mapping()
and iommu_get_domain_for_dev() functions are expected to return NULL as
an error.

However, the error checking is performed using the statement
if(IS_ERR(mapping)), which doesn't provide a suitable error value.
So check if 'mapping' is NULL, and if it is, return -ENODEV.

This issue[1] was reported by Dan.

Changelog v1:
- fix build warning.

[1] https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.mountain/

Reported-by : Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-01-20 11:51:42 +01:00
..
exynos7_drm_decon.c drm: Explicitly include correct DT includes 2023-07-21 09:12:43 +02:00
exynos5433_drm_decon.c drm: Explicitly include correct DT includes 2023-07-21 09:12:43 +02:00
exynos_dp.c drm: exynos: Remove #ifdef guards for PM related functions 2022-12-12 13:12:01 +00:00
exynos_drm_crtc.c drm/exynos: fix a possible null-pointer dereference due to data race in exynos_drm_crtc_atomic_disable() 2023-08-08 09:35:11 +09:00
exynos_drm_crtc.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
exynos_drm_dma.c drm/exynos: fix a wrong error checking 2024-01-20 11:51:42 +01:00
exynos_drm_dpi.c drm: Remove linux/fb.h from drm_crtc.h 2022-07-05 21:14:02 +03:00
exynos_drm_drv.c drm: Clear fd/handle callbacks in struct drm_driver 2023-06-26 11:08:41 +02:00
exynos_drm_drv.h drm/exynos: Remove fb_helper from struct exynos_drm_private 2023-04-17 16:47:55 +09:00
exynos_drm_dsi.c drm: Explicitly include correct DT includes 2023-07-21 09:12:43 +02:00
exynos_drm_fb.c drm/exynos: Implement fbdev emulation as in-kernel client 2023-04-17 16:47:55 +09:00
exynos_drm_fb.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
exynos_drm_fbdev.c fbdev: Use _DMAMEM_ infix for DMA-memory helpers 2023-07-31 20:07:18 +02:00
exynos_drm_fbdev.h drm/exynos: Implement fbdev emulation as in-kernel client 2023-04-17 16:47:55 +09:00
exynos_drm_fimc.c drm: exynos: Remove #ifdef guards for PM related functions 2022-12-12 13:12:01 +00:00
exynos_drm_fimd.c drm: Explicitly include correct DT includes 2023-07-21 09:12:43 +02:00
exynos_drm_g2d.c drm/exynos: fix race condition UAF in exynos_g2d_exec_ioctl 2023-06-07 13:03:16 +09:00
exynos_drm_g2d.h drm/exynos: fix g2d_open/close helper function definitions 2023-05-15 14:10:34 +09:00
exynos_drm_gem.c mm: replace vma->vm_flags direct modifications with modifier calls 2023-02-09 16:51:39 -08:00
exynos_drm_gem.h drm/exynos: Implement mmap as GEM object function 2021-12-22 11:39:39 +09:00
exynos_drm_gsc.c drm/exynos: remove redundant of_match_ptr 2023-08-08 09:35:19 +09:00
exynos_drm_ipp.c drm: Drop drm_blend.h from drm_crtc.h 2022-06-20 23:53:55 +03:00
exynos_drm_ipp.h drm/exynos: drop use of drmP.h 2019-09-01 20:55:12 +09:00
exynos_drm_mic.c drm: exynos: Remove #ifdef guards for PM related functions 2022-12-12 13:12:01 +00:00
exynos_drm_plane.c drm: Remove unnecessary include statements of drm_plane_helper.h 2022-07-26 18:42:04 +02:00
exynos_drm_plane.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
exynos_drm_rotator.c drm: Explicitly include correct DT includes 2023-07-21 09:12:43 +02:00
exynos_drm_scaler.c drm: Explicitly include correct DT includes 2023-07-21 09:12:43 +02:00
exynos_drm_vidi.c drm/exynos: vidi: fix a wrong error return 2023-06-07 13:03:17 +09:00
exynos_drm_vidi.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
exynos_hdmi.c drm/exynos: fix a potential error pointer dereference 2024-01-20 11:51:42 +01:00
exynos_mixer.c drm: Explicitly include correct DT includes 2023-07-21 09:12:43 +02:00
Kconfig fbdev: Use _DMAMEM_ infix for DMA-memory helpers 2023-07-31 20:07:18 +02:00
Makefile drm/exynos/iommu: merge IOMMU and DMA code 2018-12-04 13:23:17 +09:00
regs-decon7.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
regs-decon5433.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 423 2019-06-05 17:37:15 +02:00
regs-fimc.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
regs-gsc.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
regs-hdmi.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
regs-mixer.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
regs-rotator.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
regs-scaler.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
regs-vp.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00