Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Ben Hutchings d0e24a66ea tools/lib/lockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain/: Depth ... commit 98dcea0cfd upstream. liblockdep has been broken since commit 75dd602a51 ("lockdep: Fix lock_chain::base size"), as that adds a check that MAX_LOCK_DEPTH is within the range of lock_chain::depth and in liblockdep it is much too large. That should have resulted in a compiler error, but didn't because: - the check uses ARRAY_SIZE(), which isn't yet defined in liblockdep so is assumed to be an (undeclared) function - putting a function call inside a BUILD_BUG_ON() expression quietly turns it into some nonsense involving a variable-length array It did produce a compiler warning, but I didn't notice because liblockdep already produces too many warnings if -Wall is enabled (which I'll fix shortly). Even before that commit, which reduced lock_chain::depth from 8 bits to 6, MAX_LOCK_DEPTH was too large. Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: a.p.zijlstra@chello.nl Link: http://lkml.kernel.org/r/20170525130005.5947-3-alexander.levin@verizon.com Signed-off-by: Ingo Molnar <mingo@kernel.org>		History 2017-10-12 15:27:44 +01:00
..
cgroup	cgroups: fix cgroup_event_listener error handling	2013-01-08 10:00:44 -08:00
firewire	tools/firewire: nosy-dump: check for allocation failure	2012-12-02 20:10:18 +01:00
hv	Tools: hv: Handle the case when the target file exists correctly	2014-04-16 14:10:36 -07:00
include	perf tools: Move ACCESS_ONCE from perf.h header	2014-05-05 17:49:07 +02:00
lguest	tools/lguest: offer VIRTIO_F_ANY_LAYOUT for net device.	2013-07-15 11:18:32 +09:30
lib	tools/lib/lockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain/: Depth	2017-10-12 15:27:44 +01:00
net	tools/net: Use include/uapi with __EXPORTED_HEADERS__	2015-12-14 10:17:12 +00:00
nfsd	NFSD: Added fault injection script	2011-11-07 21:10:47 -05:00
perf	perf script python: Remove dups in documentation examples	2017-09-15 18:30:06 +01:00
power	cpupower: Fix turbo frequency reporting for pre-Sandy Bridge cores	2017-07-18 18:40:35 +01:00
scripts	tools lib traceevent: Add global QUIET_CC_FPIC build output	2013-12-19 16:18:10 -03:00
testing	selftests/powerpc: Fix TM resched DSCR test with some compilers	2017-09-15 18:29:46 +01:00
thermal/tmon	tmon: set umask to a reasonable value	2014-07-01 22:00:51 +08:00
usb	tools: ffs-test: fix header values endianess	2014-06-30 13:23:58 -05:00
virtio	tools: Consolidate types.h	2014-05-01 21:22:39 +02:00
vm	tools/vm/slabinfo: fix an unintentional printf	2016-11-20 01:16:57 +00:00
Makefile	tools: Add a "make all" rule	2016-01-25 10:43:31 +00:00