Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Ard Biesheuvel 85433307d8 crypto - shash: reduce minimum alignment of shash_desc structure ... commit 660d206219 upstream. Unlike many other structure types defined in the crypto API, the 'shash_desc' structure is permitted to live on the stack, which implies its contents may not be accessed by DMA masters. (This is due to the fact that the stack may be located in the vmalloc area, which requires a different virtual-to-physical translation than the one implemented by the DMA subsystem) Our definition of CRYPTO_MINALIGN_ATTR is based on ARCH_KMALLOC_MINALIGN, which may take DMA constraints into account on architectures that support non-cache coherent DMA such as ARM and arm64. In this case, the value is chosen to reflect the largest cacheline size in the system, in order to ensure that explicit cache maintenance as required by non-coherent DMA masters does not affect adjacent, unrelated slab allocations. On arm64, this value is currently set at 128 bytes. This means that applying CRYPTO_MINALIGN_ATTR to struct shash_desc is both unnecessary (as it is never used for DMA), and undesirable, given that it wastes stack space (on arm64, performing the alignment costs 112 bytes in the worst case, and the hole between the 'tfm' and '__ctx' members takes up another 120 bytes, resulting in an increased stack footprint of up to 232 bytes.) So instead, let's switch to the minimum SLAB alignment, which does not take DMA constraints into account. Note that this is a no-op for x86. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2021-03-09 11:11:13 +01:00
..
acpi	ACPICA: Fix exception code class checks	2021-03-04 11:37:24 +01:00
asm-generic	vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y	2021-03-04 11:37:19 +01:00
clocksource	clocksource/drivers/sp804: Remove unused sp804_timer_disable() and timer-sp804.h	2020-09-24 10:51:04 +02:00
crypto	crypto - shash: reduce minimum alignment of shash_desc structure	2021-03-09 11:11:13 +01:00
drm	drm/dp/mst: Export drm_dp_get_vc_payload_bw()	2021-02-10 09:29:18 +01:00
dt-bindings	ASoC: dt-bindings: lpass: Fix and common up lpass dai ids	2021-02-03 23:28:46 +01:00
keys	It's been a busy cycle for documentation - hopefully the busiest for a	2020-08-04 22:47:54 -07:00
kunit	kunit: fix display of failed expectations for strings	2020-11-10 13:45:15 -07:00
kvm	ARM:	2020-10-23 11:17:56 -07:00
linux	crypto - shash: reduce minimum alignment of shash_desc structure	2021-03-09 11:11:13 +01:00
math-emu	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
media	media: v4l2-fwnode: v4l2_fwnode_endpoint_parse caller must init vep argument	2020-12-30 11:53:11 +01:00
memory	memory: add Renesas RPC-IF driver	2020-07-01 22:45:14 +01:00
misc	ocxl: Don't return trigger page when allocating an interrupt	2020-08-25 01:31:31 +10:00
net	Bluetooth: Add new HCI_QUIRK_NO_SUSPEND_NOTIFIER quirk	2021-03-07 12:34:10 +01:00
pcmcia	pcmcia: Replace zero-length array with flexible-array	2020-05-18 10:28:31 +02:00
ras	mm,hwpoison: introduce MF_MSG_UNSPLIT_THP	2020-10-16 11:11:17 -07:00
rdma	RDMA: Lift ibdev_to_node from rds to common code	2021-02-26 10:12:59 +01:00
scsi	scsi: libiscsi: Fix NOP race condition	2020-11-16 22:32:50 -05:00
soc	net: dsa: felix: implement port flushing on .phylink_mac_link_down	2021-02-17 11:02:27 +01:00
sound	ASoC: Fixes for v5.11	2020-11-19 19:56:29 +01:00
target	scsi: target: Make iscsit_register_transport() return void	2020-08-04 20:56:56 -04:00
trace	trace: fix potenial dangerous pointer	2020-11-25 13:03:44 +01:00
uapi	net/sched: cls_flower: Reject invalid ct_state flags rules	2021-03-07 12:34:07 +01:00
vdso	lib/vdso: Allow to add architecture-specific vdso data	2020-08-06 10:57:30 +02:00
video	gpu: ipu-v3: remove unused functions	2020-10-26 10:42:38 +01:00
xen	Xen/gntdev: correct error checking in gntdev_map_grant_pages()	2021-02-23 15:53:24 +01:00