Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Vladimir Oltean b939d1e04a net/sched: taprio: extend minimum interval restriction to entire cycle too ... [ Upstream commit fb66df20a7 ] It is possible for syzbot to side-step the restriction imposed by the blamed commit in the Fixes: tag, because the taprio UAPI permits a cycle-time different from (and potentially shorter than) the sum of entry intervals. We need one more restriction, which is that the cycle time itself must be larger than N * ETH_ZLEN bit times, where N is the number of schedule entries. This restriction needs to apply regardless of whether the cycle time came from the user or was the implicit, auto-calculated value, so we move the existing "cycle == 0" check outside the "if "(!new->cycle_time)" branch. This way covers both conditions and scenarios. Add a selftest which illustrates the issue triggered by syzbot. Fixes: b5b73b26b3 ("taprio: Fix allowing too small intervals") Reported-by: syzbot+a7d2b1d5d1af83035567@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/0000000000007d66bc06196e7c66@google.com/ Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://lore.kernel.org/r/20240527153955.553333-2-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2024-06-12 11:12:58 +02:00
..
crypto/chacha20-s390	tools/testing/crypto: Use vzalloc instead of vmalloc+memset	2022-07-05 14:46:36 +02:00
cxl	cxl: Add cxl_num_decoders_committed() usage to cxl_test	2024-01-10 17:17:02 +01:00
fault-injection	docs: fault-injection: convert docs to ReST and rename to *.rst	2019-06-14 14:21:07 -06:00
ktest	ktest: force $buildonly = 1 for 'make_warnings_file' test type	2024-04-13 13:07:37 +02:00
kunit	kunit: tool: fix parsing of test attributes	2024-02-05 20:14:15 +00:00
memblock	memblock tests: fix warning ‘struct seq_file’ declared inside parameter list	2023-09-14 10:51:28 +03:00
nvdimm	tools/testing/nvdimm: Drop empty platform remove function	2023-06-07 13:30:21 -07:00
radix-tree	maple_tree: do not preallocate nodes for slot stores	2024-01-05 15:19:43 +01:00
scatterlist	tools/testing/scatterlist: add missing defines	2022-01-30 09:56:58 +02:00
selftests	net/sched: taprio: extend minimum interval restriction to entire cycle too	2024-06-12 11:12:58 +02:00
vsock	vsock/test: fix SEQPACKET message bounds test	2023-12-03 07:33:05 +01:00