kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-22 19:14:51 +00:00
Code Issues Releases Packages Activity
linux/drivers/gpu/drm/arm
History
Liviu Dudau 5ff7bec678 drm/komeda: Fix handling of atomic commits in the atomic_commit_tail hook 
[ Upstream commit eaa225b6b5 ]

Komeda driver relies on the generic DRM atomic helper functions to handle
commits. It only implements an atomic_commit_tail hook for the
mode_config_helper_funcs and even that one is pretty close to the generic
implementation with the exception of additional dma_fence signalling.

What the generic helper framework doesn't do is waiting for the actual
hardware to signal that the commit parameters have been written into the
appropriate registers. As we signal CRTC events only on the irq handlers,
we need to flush the configuration and wait for the hardware to respond.

Add the Komeda specific implementation for atomic_commit_hw_done() that
flushes and waits for flip done before calling drm_atomic_helper_commit_hw_done().

The fix was prompted by a patch from Carsten Haitzler where he was trying to
solve the same issue but in a different way that I think can lead to wrong
event signaling to userspace.

Reported-by: Carsten Haitzler <carsten.haitzler@arm.com>
Tested-by: Carsten Haitzler <carsten.haitzler@arm.com>
Reviewed-by: Carsten Haitzler <carsten.haitzler@arm.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220722122139.288486-1-liviu.dudau@arm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2022-10-26 12:35:38 +02:00
..
display drm/komeda: Fix handling of atomic commits in the atomic_commit_tail hook 2022-10-26 12:35:38 +02:00
hdlcd_crtc.c drm: Use state helper instead of the plane state pointer 2021-02-25 08:05:28 +01:00
hdlcd_drv.c drm/arm/hdlcd: Convert to Linux IRQ interfaces 2021-08-10 20:00:51 +02:00
hdlcd_drv.h drm/arm/hdlcd: Convert to Linux IRQ interfaces 2021-08-10 20:00:51 +02:00
hdlcd_regs.h drm: Add support for ARM's HDLCD controller. 2016-02-10 13:44:16 +00:00
Kconfig drm/arm: Kconfig annotate drivers as COMPILE_TEST 2020-06-15 14:55:21 +01:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
malidp_crtc.c drm: mali-dp: potential dereference of null pointer 2022-06-09 10:22:46 +02:00
malidp_drv.c drm/malidp: Don't set struct drm_device.irq_enabled 2021-06-29 11:08:43 +02:00
malidp_drv.h drm/arm: drop use of drmP.h 2019-08-14 18:31:15 +02:00
malidp_hw.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
malidp_hw.h drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500 2019-10-08 16:13:36 +01:00
malidp_mw.c drm: Switch to %p4cc format modifier 2021-02-17 12:52:59 +01:00
malidp_mw.h drm: mali-dp: Add writeback connector 2018-07-05 15:19:03 +01:00
malidp_planes.c drm/arm/malidp: Always list modifiers 2021-05-06 11:43:46 +02:00
malidp_regs.h drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500 2019-10-08 16:13:36 +01:00