linux/drivers/gpu/drm/ast
Jammy Huang 8a6fea3fcb drm/ast: Fix soft lockup
commit bc004f5038 upstream.

There is a while-loop in ast_dp_set_on_off() that could lead to
infinite-loop. This is because the register, VGACRI-Dx, checked in
this API is a scratch register actually controlled by a MCU, named
DPMCU, in BMC.

These scratch registers are protected by scu-lock. If suc-lock is not
off, DPMCU can not update these registers and then host will have soft
lockup due to never updated status.

DPMCU is used to control DP and relative registers to handshake with
host's VGA driver. Even the most time-consuming task, DP's link
training, is less than 100ms. 200ms should be enough.

Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
Fixes: 594e9c04b5 ("drm/ast: Create the driver for ASPEED proprietory Display-Port")
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jocelyn Falempe <jfalempe@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.19+
Link: https://patchwork.freedesktop.org/patch/msgid/20240403090246.1495487-1-jammy_huang@aspeedtech.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2024-04-17 11:18:27 +02:00
..
ast_dp.c drm/ast: Fix soft lockup 2024-04-17 11:18:27 +02:00
ast_dp501.c drm/ast: Support multiple outputs 2022-06-08 13:16:15 +02:00
ast_dram_tables.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ast_drv.c drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers 2023-08-30 16:10:57 +02:00
ast_drv.h drm/ast: Fixed the casting issue reported by sparse 2022-06-24 09:37:32 +02:00
ast_i2c.c drm/ast: Move I2C code into separate source file 2021-12-16 12:29:22 +01:00
ast_main.c drm/ast: Fix ARM compatibility 2023-06-09 10:34:07 +02:00
ast_mm.c drm/ast: Use managed interfaces for framebuffer write combining 2021-09-23 09:26:09 +02:00
ast_mode.c drm/ast: Fix video broken in some resolutions on ast2600 2022-09-20 10:20:23 +02:00
ast_post.c drm/ast: Fix DRAM init on AST2200 2023-09-19 12:27:56 +02:00
ast_tables.h drm/ast: Add resolution support for 1152x864@75 2022-09-20 10:19:32 +02:00
Kconfig drm/vram: fix Kconfig 2019-09-10 08:53:08 +02:00
Makefile drm/ast: Create the driver for ASPEED proprietory Display-Port 2022-05-03 16:04:03 +02:00