kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-11-06 18:57:23 +00:00
Code Issues Releases Packages Activity
linux/tools/net/ynl
History
Lukas Wunner 396786af1c tools: ynl-gen: Allow multi-attr without nested-attributes again 
Since commit ce6cb8113c ("tools: ynl-gen: individually free previous
values on double set"), specifying the "multi-attr" property raises an
error unless the "nested-attributes" property is specified as well:

  File "tools/net/ynl/./pyynl/ynl_gen_c.py", line 1147, in _load_nested_sets
    child = self.pure_nested_structs.get(nested)
                                         ^^^^^^
  UnboundLocalError: cannot access local variable 'nested' where it is not associated with a value

This appears to be a bug since there are existing specs which omit
"nested-attributes" on "multi-attr" attributes.  Also, according to
Documentation/userspace-api/netlink/specs.rst, multi-attr "is the
recommended way of implementing arrays (no extra nesting)", suggesting
that nesting should even be avoided in favor of multi-attr.

Fix the indentation of the if-block introduced by the commit to avoid
the error.

Fixes: ce6cb8113c ("tools: ynl-gen: individually free previous values on double set")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://patch.msgid.link/d6b58684b7e5bfb628f7313e6893d0097904e1d1.1746940107.git.lukas@wunner.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
History 2025-05-13 15:01:50 -07:00
..
generated tools: ynl: add install target for generated content 2025-01-09 12:53:27 -08:00
lib tools: ynl-gen: validate 0 len strings from kernel 2025-05-05 18:17:47 -07:00
pyynl tools: ynl-gen: Allow multi-attr without nested-attributes again 2025-05-13 15:01:50 -07:00
samples ynl: samples: Fix the wrong format specifier 2024-11-13 18:48:15 -08:00
Makefile tools: ynl: add main install target 2025-01-09 12:53:27 -08:00
Makefile.deps netlink: specs: wireless: add a spec for nl80211 2025-02-12 19:32:26 -08:00
pyproject.toml tools: ynl: add initial pyproject.toml for packaging 2025-01-09 12:53:27 -08:00
requirements.txt tools: ynl: add the Python requirements.txt file 2023-03-24 19:11:02 -07:00
ynl-regen.sh tools: ynl: move python code to separate sub-directory 2025-01-09 12:53:27 -08:00