Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Nikita Zhandarovich 6c0473c9ac drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll() ... commit 5b51157266 upstream. On the off chance that clock value ends up being too high (by means of skl_ddi_calculate_wrpll() having been called with big enough value of crtc_state->port_clock * 1000), one possible consequence may be that the result will not be able to fit into signed int. Fix this issue by moving conversion of clock parameter from kHz to Hz into the body of skl_ddi_calculate_wrpll(), as well as casting the same parameter to u64 type while calculating the value for AFE clock. This both mitigates the overflow problem and avoids possible erroneous integer promotion mishaps. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 82d3543701 ("drm/i915/skl: Implementation of SKL DPLL programming") Cc: stable@vger.kernel.org Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru> Reviewed-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240729174035.25727-1-n.zhandarovich@fintech.ru (cherry picked from commit 833cf12846) Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2024-08-11 12:47:26 +02:00
..
drm	drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()	2024-08-11 12:47:26 +02:00
host1x	gpu: host1x: Do not setup DMA for virtual devices	2024-05-17 12:02:15 +02:00
ipu-v3	drm for 6.6-rc1	2023-08-30 13:34:34 -07:00
trace	gpu/trace: add a gpu total memory usage tracepoint	2020-03-03 17:52:41 -05:00
vga	PCI/VGA: Move vgaarb to drivers/pci	2022-03-09 18:30:46 -06:00
Makefile	gpu: host1x: Add context bus	2022-06-01 11:50:42 +02:00