linux

mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-28 20:03:05 +00:00

No description

C 96.8%
Assembly 0.9%
Rust 0.7%
Shell 0.6%
Python 0.5%
Other 0.3%

Find a file

Mohamed Khalfella 57c5053eaa igb: Do not bring the device up after non-fatal error [ Upstream commit `330a699ecb` ] Commit `004d25060c` ("igb: Fix igb_down hung on surprise removal") changed igb_io_error_detected() to ignore non-fatal pcie errors in order to avoid hung task that can happen when igb_down() is called multiple times. This caused an issue when processing transient non-fatal errors. igb_io_resume(), which is called after igb_io_error_detected(), assumes that device is brought down by igb_io_error_detected() if the interface is up. This resulted in panic with stacktrace below. [ T3256] igb 0000:09:00.0 haeth0: igb: haeth0 NIC Link is Down [ T292] pcieport 0000:00:1c.5: AER: Uncorrected (Non-Fatal) error received: 0000:09:00.0 [ T292] igb 0000:09:00.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) [ T292] igb 0000:09:00.0: device [8086:1537] error status/mask=00004000/00000000 [ T292] igb 0000:09:00.0: [14] CmpltTO [ 200.105524,009][ T292] igb 0000:09:00.0: AER: TLP Header: 00000000 00000000 00000000 00000000 [ T292] pcieport 0000:00:1c.5: AER: broadcast error_detected message [ T292] igb 0000:09:00.0: Non-correctable non-fatal error reported. [ T292] pcieport 0000:00:1c.5: AER: broadcast mmio_enabled message [ T292] pcieport 0000:00:1c.5: AER: broadcast resume message [ T292] ------------[ cut here ]------------ [ T292] kernel BUG at net/core/dev.c:6539! [ T292] invalid opcode: 0000 [#1] PREEMPT SMP [ T292] RIP: 0010:napi_enable+0x37/0x40 [ T292] Call Trace: [ T292] <TASK> [ T292] ? die+0x33/0x90 [ T292] ? do_trap+0xdc/0x110 [ T292] ? napi_enable+0x37/0x40 [ T292] ? do_error_trap+0x70/0xb0 [ T292] ? napi_enable+0x37/0x40 [ T292] ? napi_enable+0x37/0x40 [ T292] ? exc_invalid_op+0x4e/0x70 [ T292] ? napi_enable+0x37/0x40 [ T292] ? asm_exc_invalid_op+0x16/0x20 [ T292] ? napi_enable+0x37/0x40 [ T292] igb_up+0x41/0x150 [ T292] igb_io_resume+0x25/0x70 [ T292] report_resume+0x54/0x70 [ T292] ? report_frozen_detected+0x20/0x20 [ T292] pci_walk_bus+0x6c/0x90 [ T292] ? aer_print_port_info+0xa0/0xa0 [ T292] pcie_do_recovery+0x22f/0x380 [ T292] aer_process_err_devices+0x110/0x160 [ T292] aer_isr+0x1c1/0x1e0 [ T292] ? disable_irq_nosync+0x10/0x10 [ T292] irq_thread_fn+0x1a/0x60 [ T292] irq_thread+0xe3/0x1a0 [ T292] ? irq_set_affinity_notifier+0x120/0x120 [ T292] ? irq_affinity_notify+0x100/0x100 [ T292] kthread+0xe2/0x110 [ T292] ? kthread_complete_and_exit+0x20/0x20 [ T292] ret_from_fork+0x2d/0x50 [ T292] ? kthread_complete_and_exit+0x20/0x20 [ T292] ret_from_fork_asm+0x11/0x20 [ T292] </TASK> To fix this issue igb_io_resume() checks if the interface is running and the device is not down this means igb_io_error_detected() did not bring the device down and there is no need to bring it up. Signed-off-by: Mohamed Khalfella <mkhalfella@purestorage.com> Reviewed-by: Yuanyuan Zhong <yzhong@purestorage.com> Fixes: `004d25060c` ("igb: Fix igb_down hung on surprise removal") Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2024-10-17 15:24:27 +02:00
arch	x86/amd_nb: Add new PCI IDs for AMD family 1Ah model 60h	2024-10-17 15:24:22 +02:00
block	blk_iocost: fix more out of bound shifts	2024-10-10 11:57:24 +02:00
certs	certs: Reference revocation list for all keyrings	2023-08-17 20:12:41 +00:00
crypto	crypto: simd - Do not call crypto_alloc_tfm during registration	2024-10-10 11:57:26 +02:00
Documentation	selftests: Introduce Makefile variable to list shared bash scripts	2024-10-17 15:24:13 +02:00
drivers	igb: Do not bring the device up after non-fatal error	2024-10-17 15:24:27 +02:00
fs	NFSv4: Prevent NULL-pointer dereference in nfs42_complete_copies()	2024-10-17 15:24:23 +02:00
include	platform/x86/intel/tpmi: Add defines to get version information	2024-10-17 15:24:26 +02:00
init	rust: fix the default format for CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT	2024-08-29 17:33:29 +02:00
io_uring	io_uring: check if we need to reschedule during overflow flush	2024-10-17 15:24:18 +02:00
ipc	sysctl: treewide: drop unused argument ctl_table_root::set_ownership(table)	2024-08-11 12:47:13 +02:00
kernel	bpf: Prevent tail call between progs attached to different hooks	2024-10-17 15:24:16 +02:00
lib	lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat	2024-10-17 15:24:13 +02:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	mm: z3fold: deprecate CONFIG_Z3FOLD	2024-10-10 11:58:02 +02:00
net	Bluetooth: RFCOMM: FIX possible deadlock in rfcomm_sk_state_change	2024-10-17 15:24:24 +02:00
rust	rust: sync: require `T: Sync` for `LockedBy::access`	2024-10-10 11:57:44 +02:00
samples	samples/bpf: Fix compilation errors with cf-protection option	2024-10-04 16:29:19 +02:00
scripts	kconfig: qconf: fix buffer overflow in debug links	2024-10-10 11:58:01 +02:00
security	tomoyo: fallback to realpath if symlink's pathname does not exist	2024-10-10 11:57:57 +02:00
sound	PCI: Add function 0 DMA alias quirk for Glenfly Arise chip	2024-10-17 15:24:16 +02:00
tools	selftests: net: no_forwarding: fix VID for $swp2 in one_bridge_two_pvids() test	2024-10-17 15:24:24 +02:00
usr	initramfs: Encode dependency on KBUILD_BUILD_TIMESTAMP	2023-06-06 17:54:49 +09:00
virt	KVM: Use dedicated mutex to protect kvm_usage_count to avoid deadlock	2024-10-04 16:29:47 +02:00
.clang-format	iommu: Add for_each_group_device()	2023-05-23 08:15:51 +02:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: set diff driver for Rust source code files	2023-05-31 17:48:25 +02:00
.gitignore	Remove *.orig pattern from .gitignore	2024-10-04 16:29:44 +02:00
.mailmap	20 hotfixes. 12 are cc:stable and the remainder address post-6.5 issues	2023-10-24 09:52:16 -10:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	USB: Remove Wireless USB and UWB documentation	2023-08-09 14:17:32 +02:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	membarrier: riscv: Add full memory barrier in switch_mm()	2024-09-12 11:11:45 +02:00
Makefile	Linux 6.6.56	2024-10-10 12:50:06 +02:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.