linux

mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-11-10 20:48:12 +00:00

No description

C 96.8%
Assembly 0.9%
Rust 0.7%
Shell 0.6%
Python 0.5%
Other 0.3%

Find a file

Jiayuan Chen 57fbbe29e8 bpf: fix ktls panic with sockmap [ Upstream commit `54a3ecaeee` ] [ 2172.936997] ------------[ cut here ]------------ [ 2172.936999] kernel BUG at lib/iov_iter.c:629! ...... [ 2172.944996] PKRU: 55555554 [ 2172.945155] Call Trace: [ 2172.945299] <TASK> [ 2172.945428] ? die+0x36/0x90 [ 2172.945601] ? do_trap+0xdd/0x100 [ 2172.945795] ? iov_iter_revert+0x178/0x180 [ 2172.946031] ? iov_iter_revert+0x178/0x180 [ 2172.946267] ? do_error_trap+0x7d/0x110 [ 2172.946499] ? iov_iter_revert+0x178/0x180 [ 2172.946736] ? exc_invalid_op+0x50/0x70 [ 2172.946961] ? iov_iter_revert+0x178/0x180 [ 2172.947197] ? asm_exc_invalid_op+0x1a/0x20 [ 2172.947446] ? iov_iter_revert+0x178/0x180 [ 2172.947683] ? iov_iter_revert+0x5c/0x180 [ 2172.947913] tls_sw_sendmsg_locked.isra.0+0x794/0x840 [ 2172.948206] tls_sw_sendmsg+0x52/0x80 [ 2172.948420] ? inet_sendmsg+0x1f/0x70 [ 2172.948634] __sys_sendto+0x1cd/0x200 [ 2172.948848] ? find_held_lock+0x2b/0x80 [ 2172.949072] ? syscall_trace_enter+0x140/0x270 [ 2172.949330] ? __lock_release.isra.0+0x5e/0x170 [ 2172.949595] ? find_held_lock+0x2b/0x80 [ 2172.949817] ? syscall_trace_enter+0x140/0x270 [ 2172.950211] ? lockdep_hardirqs_on_prepare+0xda/0x190 [ 2172.950632] ? ktime_get_coarse_real_ts64+0xc2/0xd0 [ 2172.951036] __x64_sys_sendto+0x24/0x30 [ 2172.951382] do_syscall_64+0x90/0x170 ...... After calling bpf_exec_tx_verdict(), the size of msg_pl->sg may increase, e.g., when the BPF program executes bpf_msg_push_data(). If the BPF program sets cork_bytes and sg.size is smaller than cork_bytes, it will return -ENOSPC and attempt to roll back to the non-zero copy logic. However, during rollback, msg->msg_iter is reset, but since msg_pl->sg.size has been increased, subsequent executions will exceed the actual size of msg_iter. ''' iov_iter_revert(&msg->msg_iter, msg_pl->sg.size - orig_size); ''' The changes in this commit are based on the following considerations: 1. When cork_bytes is set, rolling back to non-zero copy logic is pointless and can directly go to zero-copy logic. 2. We can not calculate the correct number of bytes to revert msg_iter. Assume the original data is "abcdefgh" (8 bytes), and after 3 pushes by the BPF program, it becomes 11-byte data: "abc?de?fgh?". Then, we set cork_bytes to 6, which means the first 6 bytes have been processed, and the remaining 5 bytes "?fgh?" will be cached until the length meets the cork_bytes requirement. However, some data in "?fgh?" is not within 'sg->msg_iter' (but in msg_pl instead), especially the data "?" we pushed. So it doesn't seem as simple as just reverting through an offset of msg_iter. 3. For non-TLS sockets in tcp_bpf_sendmsg, when a "cork" situation occurs, the user-space send() doesn't return an error, and the returned length is the same as the input length parameter, even if some data is cached. Additionally, I saw that the current non-zero-copy logic for handling corking is written as: ''' line 1177 else if (ret != -EAGAIN) { if (ret == -ENOSPC) ret = 0; goto send_end; ''' So it's ok to just return 'copied' without error when a "cork" situation occurs. Fixes: `fcb14cb1bd` ("new iov_iter flavour - ITER_UBUF") Fixes: `d3b18ad31f` ("tls: add bpf support to sk_msg handling") Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev> Acked-by: John Fastabend <john.fastabend@gmail.com> Link: https://lore.kernel.org/r/20250219052015.274405-2-jiayuan.chen@linux.dev Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2025-06-19 15:31:41 +02:00
arch	arm64/fpsimd: Do not discard modified SVE state	2025-06-19 15:31:38 +02:00
block	block: fix adding folio to bio	2025-06-10 07:12:59 -04:00
certs	sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3	2024-09-20 19:52:48 +03:00
crypto	crypto: api - Redo lookup on EEXIST	2025-06-19 15:31:30 +02:00
Documentation	dt-bindings: phy: imx8mq-usb: fix fsl,phy-tx-vboost-level-microvolt property	2025-06-10 07:13:00 -04:00
drivers	IB/cm: use rwlock for MAD agent lock	2025-06-19 15:31:40 +02:00
fs	fs/ntfs3: Add missing direct_IO in ntfs_aops_cmpr	2025-06-19 15:31:36 +02:00
include	overflow: Fix direct struct member initialization in _DEFINE_FLEX()	2025-06-19 15:31:38 +02:00
init	rust: clean Rust 1.88.0's `unnecessary_transmutes` lint	2025-05-18 08:24:51 +02:00
io_uring	io_uring: fix overflow resched cqe reordering	2025-05-29 11:03:17 +02:00
ipc	ipc: fix memleak if msg_init_ns failed in create_ipc_ns	2024-12-05 14:03:02 +01:00
kernel	bpf: Check link_create.flags parameter for multi_kprobe	2025-06-19 15:31:40 +02:00
lib	kunit/usercopy: Disable u64 test on 32-bit SPARC	2025-06-19 15:31:36 +02:00
LICENSES	LICENSES: add 0BSD license text	2024-09-01 20:43:24 -07:00
mm	mm: vmalloc: only zero-init on vrealloc shrink	2025-05-29 11:03:23 +02:00
net	bpf: fix ktls panic with sockmap	2025-06-19 15:31:41 +02:00
rust	rust: clean Rust 1.88.0's `clippy::uninlined_format_args` lint	2025-05-18 08:24:57 +02:00
samples	samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora	2025-05-29 11:02:01 +02:00
scripts	kbuild: Properly disable -Wunterminated-string-initialization for clang	2025-05-29 11:03:25 +02:00
security	smack: Revert "smackfs: Added check catlen"	2025-05-29 11:02:48 +02:00
sound	ALSA: core: fix up bus match const issues.	2025-06-19 15:31:33 +02:00
tools	selftests/bpf: Fix bpf_nf selftest failure	2025-06-19 15:31:40 +02:00
usr	kbuild: hdrcheck: fix cross build with clang	2025-03-13 13:02:18 +01:00
virt	KVM: Add member to struct kvm_gfn_range to indicate private/shared	2025-05-22 14:29:36 +02:00
.clang-format	clang-format: Update with v6.11-rc1's `for_each` macro list	2024-08-02 13:20:31 +02:00
.clippy.toml	rust: clean Rust 1.88.0's warning about `clippy::disallowed_macros` configuration	2025-05-18 08:24:51 +02:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.editorconfig	.editorconfig: remove trim_trailing_whitespace option	2024-06-13 16:47:52 +02:00
.get_maintainer.ignore	Add Jeff Kirsher to .get_maintainer.ignore	2024-03-08 11:36:54 +00:00
.gitattributes	.gitattributes: set diff driver for Rust source code files	2023-05-31 17:48:25 +02:00
.gitignore	rust: introduce `.clippy.toml`	2025-03-13 13:01:42 +01:00
.mailmap	mailmap: add entry for Thorsten Blum	2024-11-07 14:14:59 -08:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: Remove self from DSA entry	2024-11-03 12:52:38 -08:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	MAINTAINERS: Update Alexey Makhalov's email address	2025-05-22 14:29:46 +02:00
Makefile	Linux 6.12.33	2025-06-10 07:13:00 -04:00
README	README: Fix spelling	2024-03-18 03:36:32 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the reStructuredText markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.