linux/drivers/hv
Dexuan Cui 86aaa08f93 Drivers: hv: kvp: Fix two "this statement may fall through" warnings
commit fc62c3b197 upstream.

We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
the op code from the host to the userspace; when the userspace returns
the info requested by the host, we pass the info on to the host in
kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
actually doesn't cause any harm, because only message->kvp_hdr.operation
is used by the userspace, in the case of KVP_OP_GET_IP_INFO.

The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
buggy code actually doesn't cause any harm, because in the case of
KVP_OP_SET, the unexpected fall-through corrupts
message->body.kvp_set.data.key_size, but that is not really used: see
the definition of struct hv_kvp_exchg_msg_value.

Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
History 2019-02-11 17:53:26 +00:00
..
channel.c Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() 2017-06-05 21:16:49 +01:00
channel_mgmt.c Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() 2017-06-05 21:16:49 +01:00
connection.c Drivers: hv: vmbus: Use get/put_cpu() in vmbus_connect() 2018-12-16 22:09:31 +00:00
hv.c x86/retpoline/hyperv: Convert assembler indirect jumps 2018-03-19 18:59:07 +00:00
hv_balloon.c Drivers: hv: balloon: Ensure pressure reports are posted regularly 2014-05-03 19:25:17 -04:00
hv_fcopy.c Drivers: hv: hv_fcopy: fix a race condition for SMP guest 2014-07-17 18:43:10 -07:00
hv_kvp.c Drivers: hv: kvp: Fix two "this statement may fall through" warnings 2019-02-11 17:53:26 +00:00
hv_snapshot.c connector: add portid to unicast in addition to broadcasting 2014-02-07 15:40:17 -08:00
hv_util.c hv: do not lose pending heartbeat vmbus packets 2017-02-23 03:54:20 +00:00
hyperv_vmbus.h Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() 2017-06-05 21:16:49 +01:00
Kconfig x86: Make Linux guest support optional 2013-03-04 13:14:25 -08:00
Makefile Drivers: hv: Implement the file copy service 2014-02-18 10:53:48 -08:00
ring_buffer.c Drivers: hv: vmbus: Fix signaling logic in hv_need_to_signal_on_read() 2016-06-15 21:29:29 +01:00
vmbus_drv.c random: add interrupt callback to VMBus IRQ handler 2016-11-20 01:16:40 +00:00