Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

John Stultz 12a2ca67f9 selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior ... [ Upstream commit 0763613621 ] The struct adjtimex freq field takes a signed value who's units are in shifted (<<16) parts-per-million. Unfortunately for negative adjustments, the straightforward use of: freq = ppm << 16 trips undefined behavior warnings with clang: valid-adjtimex.c:66:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value] -499<<16, ~~~~^ valid-adjtimex.c:67:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value] -450<<16, ~~~~^ .. Fix it by using a multiply by (1 << 16) instead of shifting negative values in the valid-adjtimex test case. Align the values for better readability. Reported-by: Lee Jones <joneslee@google.com> Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Signed-off-by: John Stultz <jstultz@google.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/r/20240409202222.2830476-1-jstultz@google.com Link: https://lore.kernel.org/lkml/0c6d4f0d-2064-4444-986b-1d1ed782135f@collabora.com/ Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2024-05-17 11:50:54 +02:00
..
fault-injection	docs: fault-injection: convert docs to ReST and rename to *.rst	2019-06-14 14:21:07 -06:00
ktest	ktest: force $buildonly = 1 for 'make_warnings_file' test type	2024-04-13 13:01:46 +02:00
kunit	kunit: tool: Import missing importlib.abc	2022-02-23 12:03:04 +01:00
nvdimm	memremap: remove support for external pgmap refcounts	2022-08-17 14:23:43 +02:00
radix-tree	radix tree test suite: fix incorrect allocation size for pthreads	2023-08-16 18:21:58 +02:00
scatterlist	Merge branch 'akpm' (patches from Andrew)	2021-09-03 10:08:28 -07:00
selftests	selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior	2024-05-17 11:50:54 +02:00
vsock	vsock_diag_test: remove free_sock_stat() call in test_no_sockets	2021-10-15 17:21:34 -07:00