kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-18 19:12:56 +00:00
Code Issues Releases Packages Activity
linux/drivers/pci/pcie
History
Rasmus Villemoes 253dc6c3ca PCI/AER: Avoid info leak in __print_tlp_header() 
commit a1b7f2f636 upstream.

Commit fab4c256a5 ("PCI/AER: Add a TLP header print helper") introduced
the helper function __print_tlp_header(), but contrary to the intention,
the behaviour did change: Since we're taking the address of the parameter
t, the first 4 or 8 bytes printed will be the value of the pointer t
itself, and the remaining 12 or 8 bytes will be who-knows-what (something
from the stack).

We want to show the values of the four members of the struct
aer_header_log_regs; that can be done without ugly and error-prone casts.
On little-endian this should produce the same output as originally
intended, and since no-one has complained about getting garbage output so
far, I think big-endian should be ok too.

Fixes: fab4c256a5 ("PCI/AER: Add a TLP header print helper")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
History 2015-04-27 16:16:32 +01:00
..
aer PCI/AER: Avoid info leak in __print_tlp_header() 2015-04-27 16:16:32 +01:00
aspm.c PCI: Remove unused pcie_aspm_enabled() 2014-01-13 11:14:44 -07:00
Kconfig PCI changes for the v3.12 merge window: 2013-09-03 16:24:35 -07:00
Makefile PCI: PCIe: Move PCIe PME code to the pcie directory 2010-08-24 13:47:48 -07:00
pme.c PCI: Merge multi-line quoted strings 2014-06-10 20:20:42 -06:00
portdrv.h PCI: Fix whitespace, capitalization, and spelling errors 2013-11-14 11:28:18 -07:00
portdrv_acpi.c PCI: Fix missing prototype for pcie_port_acpi_setup() 2013-04-12 11:17:47 -06:00
portdrv_bus.c PCI: Fix whitespace, capitalization, and spelling errors 2013-11-14 11:28:18 -07:00
portdrv_core.c Merge branches 'pci/hotplug', 'pci/msi', 'pci/virtualization' and 'pci/misc' into next 2014-04-29 17:43:58 -06:00
portdrv_pci.c PCI: Merge multi-line quoted strings 2014-06-10 20:20:42 -06:00