Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Dan Carpenter 3aa1e32702 vhost/scsi: potential memory corruption ... commit 59c816c1f2 upstream. This code in vhost_scsi_make_tpg() is confusing because we limit "tpgt" to UINT_MAX but the data type of "tpg->tport_tpgt" and that is a u16. I looked at the context and it turns out that in vhost_scsi_set_endpoint(), "tpg->tport_tpgt" is used as an offset into the vs_tpg[] array which has VHOST_SCSI_MAX_TARGET (256) elements so anything higher than 255 then it is invalid. I have made that the limit now. In vhost_scsi_send_evt() we mask away values higher than 255, but now that the limit has changed, we don't need the mask. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> [ luis: backported to 3.16: functions rename: - tcm_vhost_send_evt -> vhost_scsi_send_evt - tcm_vhost_make_tpg -> vhost_scsi_make_tpg ] Signed-off-by: Luis Henriques <luis.henriques@canonical.com>		History 2015-03-03 14:26:02 +00:00
..
Kconfig	vhost: Make vhost a separate module	2013-07-07 17:33:44 +03:00
Makefile	vhost: Make vhost a separate module	2013-07-07 17:33:44 +03:00
net.c	vhost-net: don't open-code kvfree	2014-06-23 09:22:48 +03:00
scsi.c	vhost/scsi: potential memory corruption	2015-03-03 14:26:02 +00:00
test.c	vhost: move memory pointer to VQs	2014-06-09 16:21:07 +03:00
test.h	vhost test module	2010-12-09 16:00:21 +02:00
vhost.c	vhost: move memory pointer to VQs	2014-06-09 16:21:07 +03:00
vhost.h	vhost: move memory pointer to VQs	2014-06-09 16:21:07 +03:00
vringh.c	Add missing module license tag to vring helpers.	2013-05-08 10:49:03 +09:30