Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Mohsin Bashir 0135333914 eth: fbnic: Configure RDE settings for pause frame ... fbnic supports pause frames. When pause frames are enabled presumably user expects lossless operation from the NIC. Make sure we configure RDE (Rx DMA Engine) to DROP_NEVER mode to avoid discards due to delays in fetching Rx descriptors from the host. While at it enable DROP_NEVER when NIC only has a single queue configured. In this case the NIC acts as a FIFO so there's no risk of head-of-line blocking other queues by making RDE wait. If pause is disabled this just moves the packet loss from the DMA engine to the Rx buffer. Remove redundant call to fbnic_config_drop_mode_rcq(), introduced by commit 0cb4c0a137 ("eth: fbnic: Implement Rx queue alloc/start/stop/free"). This call does not add value as fbnic_enable_rcq(), which is called immediately afterward, already handles this. Although we do not support autoneg at this time, preserve tx_pause in .mac_link_up instead of fbnic_phylink_get_pauseparam() Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20251113232610.1151712-1-mohsin.bashr@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		History 2025-11-17 16:57:32 -08:00
..
fbnic	eth: fbnic: Configure RDE settings for pause frame	2025-11-17 16:57:32 -08:00
Kconfig	net: fbnic: Allow builds for all 64 bit architectures	2025-10-16 11:36:29 +02:00
Makefile	eth: fbnic: Add scaffolding for Meta's NIC driver	2024-07-15 12:50:42 -07:00