linux

mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-11-10 20:48:12 +00:00

No description

C 96.8%
Assembly 0.9%
Rust 0.7%
Shell 0.6%
Python 0.5%
Other 0.3%

Find a file

Lin Ma 65f69851e4 igb: revert rtnl_lock() that causes deadlock The commit `6faee3d4ee` ("igb: Add lock to avoid data race") adds rtnl_lock to eliminate a false data race shown below (FREE from device detaching) \| (USE from netdev core) igb_remove \| igb_ndo_get_vf_config igb_disable_sriov \| vf >= adapter->vfs_allocated_count? kfree(adapter->vf_data) \| adapter->vfs_allocated_count = 0 \| \| memcpy(... adapter->vf_data[vf] The above race will never happen and the extra rtnl_lock causes deadlock below [ 141.420169] <TASK> [ 141.420672] __schedule+0x2dd/0x840 [ 141.421427] schedule+0x50/0xc0 [ 141.422041] schedule_preempt_disabled+0x11/0x20 [ 141.422678] __mutex_lock.isra.13+0x431/0x6b0 [ 141.423324] unregister_netdev+0xe/0x20 [ 141.423578] igbvf_remove+0x45/0xe0 [igbvf] [ 141.423791] pci_device_remove+0x36/0xb0 [ 141.423990] device_release_driver_internal+0xc1/0x160 [ 141.424270] pci_stop_bus_device+0x6d/0x90 [ 141.424507] pci_stop_and_remove_bus_device+0xe/0x20 [ 141.424789] pci_iov_remove_virtfn+0xba/0x120 [ 141.425452] sriov_disable+0x2f/0xf0 [ 141.425679] igb_disable_sriov+0x4e/0x100 [igb] [ 141.426353] igb_remove+0xa0/0x130 [igb] [ 141.426599] pci_device_remove+0x36/0xb0 [ 141.426796] device_release_driver_internal+0xc1/0x160 [ 141.427060] driver_detach+0x44/0x90 [ 141.427253] bus_remove_driver+0x55/0xe0 [ 141.427477] pci_unregister_driver+0x2a/0xa0 [ 141.428296] __x64_sys_delete_module+0x141/0x2b0 [ 141.429126] ? mntput_no_expire+0x4a/0x240 [ 141.429363] ? syscall_trace_enter.isra.19+0x126/0x1a0 [ 141.429653] do_syscall_64+0x5b/0x80 [ 141.429847] ? exit_to_user_mode_prepare+0x14d/0x1c0 [ 141.430109] ? syscall_exit_to_user_mode+0x12/0x30 [ 141.430849] ? do_syscall_64+0x67/0x80 [ 141.431083] ? syscall_exit_to_user_mode_prepare+0x183/0x1b0 [ 141.431770] ? syscall_exit_to_user_mode+0x12/0x30 [ 141.432482] ? do_syscall_64+0x67/0x80 [ 141.432714] ? exc_page_fault+0x64/0x140 [ 141.432911] entry_SYSCALL_64_after_hwframe+0x72/0xdc Since the igb_disable_sriov() will call pci_disable_sriov() before releasing any resources, the netdev core will synchronize the cleanup to avoid any races. This patch removes the useless rtnl_(un)lock to guarantee correctness. CC: stable@vger.kernel.org Fixes: `6faee3d4ee` ("igb: Add lock to avoid data race") Reported-by: Corinna Vinschen <vinschen@redhat.com> Link: https://lore.kernel.org/intel-wired-lan/ZAcJvkEPqWeJHO2r@calimero.vinschen.de/ Signed-off-by: Lin Ma <linma@zju.edu.cn> Tested-by: Corinna Vinschen <vinschen@redhat.com> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>		History 2023-03-16 08:55:26 -07:00
arch	bpf-for-netdev	2023-03-06 20:28:00 -08:00
block	Driver core changes for 6.3-rc1	2023-02-24 12:58:55 -08:00
certs	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
crypto	Networking changes for 6.3.	2023-02-21 18:24:12 -08:00
Documentation	ynl: re-license uniformly under GPL-2.0 OR BSD-3-Clause	2023-03-07 13:44:30 -08:00
drivers	igb: revert rtnl_lock() that causes deadlock	2023-03-16 08:55:26 -07:00
fs	ARM: SoC drivers for 6.3	2023-02-27 10:04:49 -08:00
include	ynl: re-license uniformly under GPL-2.0 OR BSD-3-Clause	2023-03-07 13:44:30 -08:00
init	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
io_uring	- Daniel Verkamp has contributed a memfd series ("mm/memfd: add	2023-02-23 17:09:35 -08:00
ipc	Merge branch 'work.namespace' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2023-02-24 19:20:07 -08:00
kernel	bpf-for-netdev	2023-03-06 20:28:00 -08:00
lib	Kernel concurrency sanitizer (KCSAN) updates for v6.3	2023-02-25 13:02:20 -08:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	memblock: small optimizations	2023-02-27 09:34:53 -08:00
net	net/smc: fix fallback failed while sendmsg with fastopen	2023-03-08 13:00:55 +00:00
rust	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
samples	VFIO updates for v6.3-rc1	2023-02-25 11:52:57 -08:00
scripts	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
security	powerpc updates for 6.3	2023-02-25 11:00:06 -08:00
sound	ARM: SoC drivers for 6.3	2023-02-27 10:04:49 -08:00
tools	ynl: re-license uniformly under GPL-2.0 OR BSD-3-Clause	2023-03-07 13:44:30 -08:00
usr	usr/gen_init_cpio.c: remove unnecessary -1 values from int file	2022-10-03 14:21:44 -07:00
virt	KVM/riscv changes for 6.3	2023-02-15 12:33:28 -05:00
.clang-format	media: subdev: Add for_each_active_route() macro	2023-01-22 09:35:57 +01:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for *.dtso files	2023-02-26 15:28:23 +09:00
.gitignore	.gitignore: ignore .cover and .mbx	2023-02-05 18:51:22 +09:00
.mailmap	mailmap: update entries for Stephen Hemminger	2023-03-07 13:43:56 -08:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	There is no particular theme here - mainly quick hits all over the tree.	2023-02-23 17:55:40 -08:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	ARM: SoC fixes for 6.3, part 1	2023-02-27 10:09:40 -08:00
Makefile	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.