linux/fs/dlm
Alexander Aring 2db11504ef dlm: fix possible lkb_resource null dereference
[ Upstream commit b98333c67d ]

This patch fixes a possible null pointer dereference when this function is
called from request_lock() as lkb->lkb_resource is not assigned yet,
only after validate_lock_args() by calling attach_lkb(). Another issue
is that a resource name could be a non printable bytearray and we cannot
assume to be ASCII coded.

The log functionality is probably never being hit when DLM is used in
normal way and no debug logging is enabled. The null pointer dereference
can only occur on a new created lkb that does not have the resource
assigned yet, it probably never hits the null pointer dereference but we
should be sure that other changes might not change this behaviour and we
actually can hit the mentioned null pointer dereference.

In this patch we just drop the printout of the resource name, the lkb id
is enough to make a possible connection to a resource name if this
exists.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-12-14 20:03:44 +01:00
..
ast.c dlm: fix swapped args sb_flags vs sb_status 2024-12-05 14:01:41 +01:00
ast.h dlm: implement LSFL_SOFTIRQ_SAFE 2024-06-11 13:13:00 -05:00
config.c dlm: never return invalid nodeid by dlm_our_nodeid() 2024-08-08 15:15:07 -05:00
config.h dlm: switch to use rhashtable for rsbs 2024-04-16 14:34:39 -05:00
debug_fs.c [tree-wide] finally take no_llseek out 2024-09-27 08:18:43 -07:00
dir.c dlm: use rwlock for rsb hash table 2024-04-16 14:45:31 -05:00
dir.h dlm: move rsb root_list to ls_recover() stack 2024-04-09 11:44:49 -05:00
dlm_internal.h dlm: move lkb xarray lookup out of lock 2024-08-08 15:15:08 -05:00
Kconfig fs: dlm: remove deprecated code parts 2023-03-06 15:49:07 -06:00
lock.c dlm: fix possible lkb_resource null dereference 2024-12-14 20:03:44 +01:00
lock.h dlm: warn about invalid nodeid comparsions 2024-08-08 15:15:07 -05:00
lockspace.c dlm: async freeing of lockspace resources 2024-08-08 15:15:08 -05:00
lockspace.h fs: dlm: revert check required context while close 2023-06-14 10:17:33 -05:00
lowcomms.c dlm: do synchronized socket connect call 2024-08-08 15:15:08 -05:00
lowcomms.h dlm: remove unused parameter in dlm_midcomms_addr 2024-05-31 11:04:54 -05:00
lvb_table.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 193 2019-05-30 11:29:21 -07:00
main.c dlm: add missing -ENOMEM if alloc_workqueue() fails 2024-08-12 15:16:18 -05:00
Makefile fs: dlm: remove deprecated code parts 2023-03-06 15:49:07 -06:00
member.c dlm: warn about invalid nodeid comparsions 2024-08-08 15:15:07 -05:00
member.h fs: dlm: constify receive buffer 2023-08-10 10:33:03 -05:00
memory.c dlm: move lkb xarray lookup out of lock 2024-08-08 15:15:08 -05:00
memory.h dlm: cleanup memory allocation helpers 2024-08-08 15:14:41 -05:00
midcomms.c dlm: remove unused parameter in dlm_midcomms_addr 2024-05-31 11:04:54 -05:00
midcomms.h dlm: remove unused parameter in dlm_midcomms_addr 2024-05-31 11:04:54 -05:00
plock.c dlm: adapt to breakup of struct file_lock 2024-02-05 13:11:42 +01:00
rcom.c dlm: use spin_lock_bh for message processing 2024-04-09 11:45:23 -05:00
rcom.h fs: dlm: constify receive buffer 2023-08-10 10:33:03 -05:00
recover.c dlm: warn about invalid nodeid comparsions 2024-08-08 15:15:07 -05:00
recover.h dlm: change list and timer names 2024-06-10 15:11:46 -05:00
recoverd.c dlm: fix dlm_recover_members refcount on error 2024-12-05 14:02:00 +01:00
recoverd.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 193 2019-05-30 11:29:21 -07:00
requestqueue.c dlm: use spin_lock_bh for message processing 2024-04-09 11:45:23 -05:00
requestqueue.h fs: dlm: constify receive buffer 2023-08-10 10:33:03 -05:00
user.c dlm: implement LSFL_SOFTIRQ_SAFE 2024-06-11 13:13:00 -05:00
user.h fs: dlm: move dlm_purge_lkb_callbacks to user module 2023-06-14 10:17:33 -05:00
util.c dlm: use __le types for dlm messages 2022-04-06 14:02:37 -05:00
util.h dlm: use __le types for dlm messages 2022-04-06 14:02:37 -05:00