linux/drivers/media
Hans Verkuil d9e7c172a7 media: rtl2832_sdr: assign vb2 lock before vb2_queue_init
Commit c780d01cf1 ("media: vb2: vb2_core_queue_init(): sanity check lock
and wait_prepare/finish") added a sanity check to ensure that if there are
no wait_prepare/finish callbacks set by the driver, then the vb2_queue lock
must be set, since otherwise the vb2 core cannot do correct locking.

The rtl2832_sdr.c triggered this warning: it turns out that while the
driver does set this lock, it sets it too late. So move it up to before
the vb2_queue_init() call.

Reported-by: Arthur Marsh <arthur.marsh@internode.on.net>
Closes: https://lore.kernel.org/linux-media/20241211042355.8479-1-user@am64/
Fixes: 8fcd2795d2 ("media: rtl2832_sdr: drop vb2_ops_wait_prepare/finish")
Cc: stable@vger.kernel.org
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
History 2025-03-12 16:43:51 +01:00
..
cec media: cec: include linux/debugfs.h and linux/seq_file.h where needed 2025-01-07 12:21:38 +01:00
common [GIT PULL for v6.14] media updates 2025-01-25 15:59:46 -08:00
dvb-core media: fix secfeed undefined when filter alloc fail 2025-01-08 12:52:36 +01:00
dvb-frontends media: rtl2832_sdr: assign vb2 lock before vb2_queue_init 2025-03-12 16:43:51 +01:00
firewire media: firewire: firedtv-avc.c: replace BUG with proper, error return 2023-08-10 07:58:37 +02:00
i2c [GIT PULL for v6.14] media updates 2025-01-25 15:59:46 -08:00
mc media updates for v6.13-rc1 2024-11-20 14:01:15 -08:00
mmc media: mmc: siano: simplify module initialization 2024-04-08 13:48:19 +02:00
pci Driver core and debugfs updates 2025-01-28 12:25:12 -08:00
platform [GIT PULL for v6.14] media updates 2025-01-25 15:59:46 -08:00
radio media: remove dead TI wl128x FM radio driver 2024-12-02 14:05:23 +01:00
rc media: rc: iguanair: handle timeouts 2024-12-11 19:48:17 +01:00
spi media: gs1662: remove unused struct 'gs_reg_fmt_custom' 2024-05-31 13:51:16 +02:00
test-drivers media: vidtv: Fix a null-ptr-deref in vidtv_mux_stop_thread 2025-01-07 12:21:39 +01:00
tuners media: tuners: fc0013 Remove unused functions 2024-12-02 14:05:25 +01:00
usb Revert "media: uvcvideo: Require entities to have a non-zero unique ID" 2025-01-31 22:07:43 +01:00
v4l2-core media: mc: fix endpoint iteration 2024-12-19 12:50:17 +01:00
Kconfig media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y 2022-12-07 17:58:46 +01:00
Makefile media: Makefiles: remove extra spaces 2022-03-12 16:59:52 +01:00