Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Patrisious Haddad cf32affe6f RDMA/mlx5: Fix error flow upon firmware failure for RQ destruction ... [ Upstream commit 5d2ea5aebb ] Upon RQ destruction if the firmware command fails which is the last resource to be destroyed some SW resources were already cleaned regardless of the failure. Now properly rollback the object to its original state upon such failure. In order to avoid a use-after free in case someone tries to destroy the object again, which results in the following kernel trace: refcount_t: underflow; use-after-free. WARNING: CPU: 0 PID: 37589 at lib/refcount.c:28 refcount_warn_saturate+0xf4/0x148 Modules linked in: rdma_ucm(OE) rdma_cm(OE) iw_cm(OE) ib_ipoib(OE) ib_cm(OE) ib_umad(OE) mlx5_ib(OE) rfkill mlx5_core(OE) mlxdevm(OE) ib_uverbs(OE) ib_core(OE) psample mlxfw(OE) mlx_compat(OE) macsec tls pci_hyperv_intf sunrpc vfat fat virtio_net net_failover failover fuse loop nfnetlink vsock_loopback vmw_vsock_virtio_transport_common vmw_vsock_vmci_transport vmw_vmci vsock xfs crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce virtio_console virtio_gpu virtio_blk virtio_dma_buf virtio_mmio dm_mirror dm_region_hash dm_log dm_mod xpmem(OE) CPU: 0 UID: 0 PID: 37589 Comm: python3 Kdump: loaded Tainted: G OE ------- --- 6.12.0-54.el10.aarch64 #1 Tainted: [O]=OOT_MODULE, [E]=UNSIGNED_MODULE Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015 pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : refcount_warn_saturate+0xf4/0x148 lr : refcount_warn_saturate+0xf4/0x148 sp : ffff80008b81b7e0 x29: ffff80008b81b7e0 x28: ffff000133d51600 x27: 0000000000000001 x26: 0000000000000000 x25: 00000000ffffffea x24: ffff00010ae80f00 x23: ffff00010ae80f80 x22: ffff0000c66e5d08 x21: 0000000000000000 x20: ffff0000c66e0000 x19: ffff00010ae80340 x18: 0000000000000006 x17: 0000000000000000 x16: 0000000000000020 x15: ffff80008b81b37f x14: 0000000000000000 x13: 2e656572662d7265 x12: ffff80008283ef78 x11: ffff80008257efd0 x10: ffff80008283efd0 x9 : ffff80008021ed90 x8 : 0000000000000001 x7 : 00000000000bffe8 x6 : c0000000ffff7fff x5 : ffff0001fb8e3408 x4 : 0000000000000000 x3 : ffff800179993000 x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff000133d51600 Call trace: refcount_warn_saturate+0xf4/0x148 mlx5_core_put_rsc+0x88/0xa0 [mlx5_ib] mlx5_core_destroy_rq_tracked+0x64/0x98 [mlx5_ib] mlx5_ib_destroy_wq+0x34/0x80 [mlx5_ib] ib_destroy_wq_user+0x30/0xc0 [ib_core] uverbs_free_wq+0x28/0x58 [ib_uverbs] destroy_hw_idr_uobject+0x34/0x78 [ib_uverbs] uverbs_destroy_uobject+0x48/0x240 [ib_uverbs] __uverbs_cleanup_ufile+0xd4/0x1a8 [ib_uverbs] uverbs_destroy_ufile_hw+0x48/0x120 [ib_uverbs] ib_uverbs_close+0x2c/0x100 [ib_uverbs] __fput+0xd8/0x2f0 __fput_sync+0x50/0x70 __arm64_sys_close+0x40/0x90 invoke_syscall.constprop.0+0x74/0xd0 do_el0_svc+0x48/0xe8 el0_svc+0x44/0x1d0 el0t_64_sync_handler+0x120/0x130 el0t_64_sync+0x1a4/0x1a8 Fixes: e2013b212f ("net/mlx5_core: Add RQ and SQ event handling") Signed-off-by: Patrisious Haddad <phaddad@nvidia.com> Link: https://patch.msgid.link/3181433ccdd695c63560eeeb3f0c990961732101.1745839855.git.leon@kernel.org Signed-off-by: Leon Romanovsky <leon@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2025-06-27 11:07:10 +01:00
..
cq.h	net/mlx5: Use mlx5_cmd_do() in core create_{cq,dct}	2022-02-23 15:21:59 -08:00
device.h	net/mlx5: E-Switch, properly handle ingress tagged packets on VST	2023-01-12 12:02:09 +01:00
doorbell.h	net/mlx5: Remove spinlock support from mlx5_write64	2019-04-02 12:49:37 -07:00
driver.h	RDMA/mlx5: Fix error flow upon firmware failure for RQ destruction	2025-06-27 11:07:10 +01:00
eq.h	net/mlx5: Introduce API for bulk request and release of IRQs	2022-01-06 16:22:52 -08:00
eswitch.h	net/mlx5: E-switch, Remove dependency between sriov and eswitch mode	2022-07-02 11:58:26 -07:00
fs.h	net/mlx5: Add MACsec Rx tables support to fs_core	2022-09-07 14:02:08 +01:00
fs_helpers.h	net/mlx5: Remove unused functions	2022-09-27 12:50:27 -07:00
mlx5_ifc.h	net/mlx5: Correct TASR typo into TSAR	2024-09-18 19:23:05 +02:00
mlx5_ifc_fpga.h	net/mlx5: Remove from FPGA IFC file not-needed definitions	2022-09-27 12:50:27 -07:00
mlx5_ifc_vdpa.h	vdpa/mlx5: Implement susupend virtqueue callback	2022-08-11 04:26:08 -04:00
mpfs.h	{net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table	2021-05-18 23:01:48 -07:00
port.h	IB/mlx5: Fix undefined behavior due to shift overflowing the constant	2022-04-06 10:15:03 +03:00
qp.h	RDMA/mlx5: Use sq timestamp as QP timestamp when RoCE is disabled	2024-08-03 08:49:20 +02:00
rsc_dump.h	net/mlx5: Add support in query QP, CQ and MKEY segments	2020-06-23 17:26:10 +03:00
transobj.h	net/mlx5e: Fix page reclaim for dead peer hairpin	2021-06-09 17:20:03 -07:00
vport.h	net/mlx5: E-Switch, Prepare to return total vports from eswitch struct	2021-04-24 00:58:43 -07:00