Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Anand Moon 77511c2d2d perf/amlogic: Replace smp_processor_id() with raw_smp_processor_id() in meson_ddr_pmu_create() ... [ Upstream commit 097469a2b0 ] The Amlogic DDR PMU driver meson_ddr_pmu_create() function incorrectly uses smp_processor_id(), which assumes disabled preemption. This leads to kernel warnings during module loading because meson_ddr_pmu_create() can be called in a preemptible context. Following kernel warning and stack trace: [ 31.745138] [ T2289] BUG: using smp_processor_id() in preemptible [00000000] code: (udev-worker)/2289 [ 31.745154] [ T2289] caller is debug_smp_processor_id+0x28/0x38 [ 31.745172] [ T2289] CPU: 4 UID: 0 PID: 2289 Comm: (udev-worker) Tainted: GW 6.14.0-0-MANJARO-ARM #1 59519addcbca6ba8de735e151fd7b9e97aac7ff0 [ 31.745181] [ T2289] Tainted: [W]=WARN [ 31.745183] [ T2289] Hardware name: Hardkernel ODROID-N2Plus (DT) [ 31.745188] [ T2289] Call trace: [ 31.745191] [ T2289] show_stack+0x28/0x40 (C) [ 31.745199] [ T2289] dump_stack_lvl+0x4c/0x198 [ 31.745205] [ T2289] dump_stack+0x20/0x50 [ 31.745209] [ T2289] check_preemption_disabled+0xec/0xf0 [ 31.745213] [ T2289] debug_smp_processor_id+0x28/0x38 [ 31.745216] [ T2289] meson_ddr_pmu_create+0x200/0x560 [meson_ddr_pmu_g12 8095101c49676ad138d9961e3eddaee10acca7bd] [ 31.745237] [ T2289] g12_ddr_pmu_probe+0x20/0x38 [meson_ddr_pmu_g12 8095101c49676ad138d9961e3eddaee10acca7bd] [ 31.745246] [ T2289] platform_probe+0x98/0xe0 [ 31.745254] [ T2289] really_probe+0x144/0x3f8 [ 31.745258] [ T2289] __driver_probe_device+0xb8/0x180 [ 31.745261] [ T2289] driver_probe_device+0x54/0x268 [ 31.745264] [ T2289] __driver_attach+0x11c/0x288 [ 31.745267] [ T2289] bus_for_each_dev+0xfc/0x160 [ 31.745274] [ T2289] driver_attach+0x34/0x50 [ 31.745277] [ T2289] bus_add_driver+0x160/0x2b0 [ 31.745281] [ T2289] driver_register+0x78/0x120 [ 31.745285] [ T2289] __platform_driver_register+0x30/0x48 [ 31.745288] [ T2289] init_module+0x30/0xfe0 [meson_ddr_pmu_g12 8095101c49676ad138d9961e3eddaee10acca7bd] [ 31.745298] [ T2289] do_one_initcall+0x11c/0x438 [ 31.745303] [ T2289] do_init_module+0x68/0x228 [ 31.745311] [ T2289] load_module+0x118c/0x13a8 [ 31.745315] [ T2289] __arm64_sys_finit_module+0x274/0x390 [ 31.745320] [ T2289] invoke_syscall+0x74/0x108 [ 31.745326] [ T2289] el0_svc_common+0x90/0xf8 [ 31.745330] [ T2289] do_el0_svc+0x2c/0x48 [ 31.745333] [ T2289] el0_svc+0x60/0x150 [ 31.745337] [ T2289] el0t_64_sync_handler+0x80/0x118 [ 31.745341] [ T2289] el0t_64_sync+0x1b8/0x1c0 Changes replaces smp_processor_id() with raw_smp_processor_id() to ensure safe CPU ID retrieval in preemptible contexts. Cc: Jiucheng Xu <jiucheng.xu@amlogic.com> Fixes: 2016e2113d ("perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver") Signed-off-by: Anand Moon <linux.amoon@gmail.com> Link: https://lore.kernel.org/r/20250407063206.5211-1-linux.amoon@gmail.com Signed-off-by: Will Deacon <will@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2025-06-19 15:28:08 +02:00
..
amlogic	perf/amlogic: Replace smp_processor_id() with raw_smp_processor_id() in meson_ddr_pmu_create()	2025-06-19 15:28:08 +02:00
arm_cspmu	perf: arm_cspmu: Reject events meant for other PMUs	2023-11-28 17:19:54 +00:00
hisilicon	drivers/perf: hisi_pcie: Fix TLP headers bandwidth counting	2024-10-04 16:28:53 +02:00
alibaba_uncore_drw_pmu.c	drivers/perf: Fix ali_drw_pmu driver interrupt status clearing	2024-10-04 16:28:51 +02:00
apple_m1_cpu_pmu.c	drivers/perf: apple_m1: Force 63bit counters for M2 CPUs	2023-06-05 15:39:59 +01:00
arm-cci.c	drivers/perf: Explicitly include correct DT includes	2023-07-27 13:02:23 +01:00
arm-ccn.c	drivers/perf:Directly use ida_alloc()/free()	2022-06-23 15:44:45 +01:00
arm-cmn.c	perf/arm-cmn: Initialise cmn->cpu earlier	2025-06-04 14:42:24 +02:00
arm_dmc620_pmu.c	perf/arm-dmc620: Fix lockdep assert in ->event_init()	2024-06-12 11:12:46 +02:00
arm_dsu_pmu.c	drivers/perf: Explicitly include correct DT includes	2023-07-27 13:02:23 +01:00
arm_pmu.c	perf: arm_pmu: Don't disable counter in armpmu_add()	2025-04-25 10:45:10 +02:00
arm_pmu_acpi.c	arm_pmu: acpi: Add a representative platform device for TRBE	2023-08-18 18:07:10 +01:00
arm_pmu_platform.c	drivers/perf: Explicitly include correct DT includes	2023-07-27 13:02:23 +01:00
arm_pmuv3.c	perf: arm_pmuv3: Call kvm_vcpu_pmu_resync_el0() before enabling counters	2025-06-04 14:42:04 +02:00
arm_smmuv3_pmu.c	perf/arm-smmuv3: Fix lockdep assert in ->event_init()	2024-12-09 10:32:57 +01:00
arm_spe_pmu.c	drivers/perf: arm_spe: Use perf_allow_kernel() for permissions	2024-10-10 11:57:27 +02:00
cxl_pmu.c	perf: CXL: fix CPMU filter value mask length	2024-03-26 18:19:12 -04:00
fsl_imx8_ddr_perf.c	perf/imx_ddr: don't enable counter0 if none of 4 counters are used	2023-08-16 14:34:51 +01:00
fsl_imx9_ddr_perf.c	perf: imx_perf: fix counter start and config sequence	2024-08-11 12:47:17 +02:00
Kconfig	perf/smmuv3: Remove build dependency on ACPI	2023-07-27 13:00:49 +01:00
Makefile	cxl for v6.5	2023-07-01 08:58:41 -07:00
marvell_cn10k_ddr_pmu.c	drivers/perf: Explicitly include correct DT includes	2023-07-27 13:02:23 +01:00
marvell_cn10k_tad_pmu.c	drivers/perf: Explicitly include correct DT includes	2023-07-27 13:02:23 +01:00
qcom_l2_pmu.c	perf: qcom_l2_pmu: Make l2_cache_pmu_probe_cluster() more robust	2023-06-05 15:01:27 +01:00
qcom_l3_pmu.c	perf: qcom: Use devm_platform_get_and_ioremap_resource()	2023-03-27 15:03:01 +01:00
riscv_pmu.c	drivers/perf: riscv: Disable PERF_SAMPLE_BRANCH_* while not supported	2024-04-10 16:35:58 +02:00
riscv_pmu_legacy.c	drivers: perf: ctr_get_width function for legacy is not defined	2024-03-06 14:48:38 +00:00
riscv_pmu_sbi.c	perf: riscv: Fix selecting counters in legacy mode	2024-08-11 12:47:23 +02:00
thunderx2_pmu.c	perf: Replace acpi_bus_get_device()	2022-02-08 15:14:53 +00:00
xgene_pmu.c	perf: xgene_pmu: Convert to devm_platform_ioremap_resource()	2023-07-27 13:00:10 +01:00