Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Bart Van Assche e193b7955d RDMA/srp: Do not call scsi_done() from srp_abort() ... After scmd_eh_abort_handler() has called the SCSI LLD eh_abort_handler callback, it performs one of the following actions: * Call scsi_queue_insert(). * Call scsi_finish_command(). * Call scsi_eh_scmd_add(). Hence, SCSI abort handlers must not call scsi_done(). Otherwise all the above actions would trigger a use-after-free. Hence remove the scsi_done() call from srp_abort(). Keep the srp_free_req() call before returning SUCCESS because we may not see the command again if SUCCESS is returned. Cc: Bob Pearson <rpearsonhpe@gmail.com> Cc: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com> Fixes: d853667091 ("IB/srp: Avoid having aborted requests hang") Signed-off-by: Bart Van Assche <bvanassche@acm.org> Link: https://lore.kernel.org/r/20230823205727.505681-1-bvanassche@acm.org Signed-off-by: Leon Romanovsky <leon@kernel.org>		History 2023-09-11 14:15:58 +03:00
..
ipoib	v6.3 RDMA pull request	2023-02-24 15:11:03 -08:00
iser	v6.4 merge window RDMA pull request	2023-04-29 17:21:24 -07:00
isert	Revert "IB/isert: Fix incorrect release of isert connection"	2023-08-22 17:01:04 +03:00
opa_vnic	IB: move from strlcpy with unused retval to strscpy	2022-08-21 14:18:02 +03:00
rtrs	RDMA: Make all 'class' structures const	2023-08-08 13:25:15 +03:00
srp	RDMA/srp: Do not call scsi_done() from srp_abort()	2023-09-11 14:15:58 +03:00
srpt	v6.4 merge window RDMA pull request	2023-04-29 17:21:24 -07:00
Makefile	RDMA/rtrs: include client and server modules into kernel compilation	2020-05-17 18:57:15 -03:00