Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Jiasheng Jiang d493e0bfc7 RDMA/rxe: Fix double free in rxe_srq_from_init ... commit 0beefd0e15 upstream. In rxe_srq_from_init(), the queue pointer 'q' is assigned to 'srq->rq.queue' before copying the SRQ number to user space. If copy_to_user() fails, the function calls rxe_queue_cleanup() to free the queue, but leaves the now-invalid pointer in 'srq->rq.queue'. The caller of rxe_srq_from_init() (rxe_create_srq) eventually calls rxe_srq_cleanup() upon receiving the error, which triggers a second rxe_queue_cleanup() on the same memory, leading to a double free. The call trace looks like this: kmem_cache_free+0x.../0x... rxe_queue_cleanup+0x1a/0x30 [rdma_rxe] rxe_srq_cleanup+0x42/0x60 [rdma_rxe] rxe_elem_release+0x31/0x70 [rdma_rxe] rxe_create_srq+0x12b/0x1a0 [rdma_rxe] ib_create_srq_user+0x9a/0x150 [ib_core] Fix this by moving 'srq->rq.queue = q' after copy_to_user. Fixes: aae0484e15 ("IB/rxe: avoid srq memory leak") Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> Link: https://patch.msgid.link/20260112015412.29458-1-jiashengjiangcool@gmail.com Reviewed-by: Zhu Yanjun <yanjun.Zhu@linux.dev> Signed-off-by: Leon Romanovsky <leon@kernel.org> [bwh: Backported to 5.15: There was no assignment to init->attr.max_wr here; don't add it] Signed-off-by: Ben Hutchings <benh@debian.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2026-06-19 13:33:25 +02:00
..
core	RDMA/core: Prefer NLA_NUL_STRING	2026-06-01 17:35:36 +02:00
hw	RDMA/vmw_pvrdma: Fix double free on pvrdma_alloc_ucontext() error path	2026-06-01 17:35:24 +02:00
sw	RDMA/rxe: Fix double free in rxe_srq_from_init	2026-06-19 13:33:25 +02:00
ulp	RDMA/rtrs: Fix use-after-free in path file creation cleanup	2026-06-01 17:35:51 +02:00
Kconfig	RDMA/irdma: Add irdma Kconfig/Makefile and remove i40iw	2021-06-02 20:06:36 -03:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00