linux/sound/hda
Richard Fitzgerald 90df4957a3 ALSA: hda: cs35l56: Fix uninitialized value in cs35l56_hda_read_acpi()
Eliminate the uninitialized 'nval' in cs35l56_hda_read_acpi() if a
system-specific quirk overrides processing of the dev-index property.
The value is now stored in a new 'num_amps' member of struct cs35l56_hda
so that the quirk handler can set the value.

The quirk for the Lenovo Yoga Book 9i GenX  replaces the values from the
dev-index property with hardcoded indexes. So cs35l56_hda_read_acpi() would
then skip reading the property. But this left the 'nval' local variable
uninitialized when it is later passed to cirrus_scodec_get_speaker_id().

Fixes: 40b1c2f9b2 ("ALSA: hda/cs35l56: Workaround bad dev-index on Lenovo Yoga Book 9i GenX")
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/linux-sound/aenFesLAStjrVNy8@stanley.mountain/T/#u
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20260428130531.169600-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
History 2026-04-29 07:50:16 +02:00
..
codecs ALSA: hda: cs35l56: Fix uninitialized value in cs35l56_hda_read_acpi() 2026-04-29 07:50:16 +02:00
common ALSA: hda/intel: Move firmware loading into the probe work 2026-04-16 10:33:06 +02:00
controllers ALSA: hda/intel: Move firmware loading into the probe work 2026-04-16 10:33:06 +02:00
core ALSA: hda: Avoid WARN_ON() for HDMI chmap slot checks 2026-04-29 07:49:09 +02:00
Kconfig ALSA: hda: Move codec drivers into sound/hda/codecs directory 2025-07-11 09:55:37 +02:00
Makefile ALSA: hda: Drop old codec binding method 2025-07-11 09:55:38 +02:00