linux/drivers/net/wan
Arnd Bergmann e725a66c02 farsync: fix off-by-one bug in fst_add_one
gcc-6 finds an out of bounds access in the fst_add_one function
when calculating the end of the mmio area:

drivers/net/wan/farsync.c: In function 'fst_add_one':
drivers/net/wan/farsync.c:418:53: error: index 2 denotes an offset greater than size of 'u8[2][8192] {aka unsigned char[2][8192]}' [-Werror=array-bounds]
 #define BUF_OFFSET(X)   (BFM_BASE + offsetof(struct buf_window, X))
                                                     ^
include/linux/compiler-gcc.h:158:21: note: in definition of macro '__compiler_offsetof'
  __builtin_offsetof(a, b)
                     ^
drivers/net/wan/farsync.c:418:37: note: in expansion of macro 'offsetof'
 #define BUF_OFFSET(X)   (BFM_BASE + offsetof(struct buf_window, X))
                                     ^~~~~~~~
drivers/net/wan/farsync.c:2519:36: note: in expansion of macro 'BUF_OFFSET'
                                  + BUF_OFFSET ( txBuffer[i][NUM_TX_BUFFER][0]);
                                    ^~~~~~~~~~

The warning is correct, but not critical because this appears
to be a write-only variable that is set by each WAN driver but
never accessed afterwards.

I'm taking the minimal fix here, using the correct pointer by
pointing 'mem_end' to the last byte inside of the register area
as all other WAN drivers do, rather than the first byte outside of
it. An alternative would be to just remove the mem_end member
entirely.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
History 2016-03-14 13:09:49 -04:00
..
lmc wan: lmc: Switch to using managed resources 2016-03-02 13:43:03 -05:00
.gitignore gitignore: misc files 2006-01-01 22:21:50 +01:00
c101.c drivers/net: Remove unnecessary k.alloc/v.alloc OOM messages 2012-01-31 16:20:21 -05:00
cosa.c cosa: missing error code on failure in probe() 2015-08-12 16:53:11 -07:00
cosa.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dlci.c net: Pass a "more" indication down into netdev_start_xmit() code paths. 2014-09-01 17:39:55 -07:00
dscc4.c dscc4: Undefined signed int shift 2016-02-13 06:10:21 -05:00
farsync.c farsync: fix off-by-one bug in fst_add_one 2016-03-14 13:09:49 -04:00
farsync.h WAN: farsync driver no longer uses syncppp.c directly 2008-07-23 23:00:38 +02:00
hd64570.c drivers/net: delete non-required instances of include <linux/init.h> 2014-01-16 11:53:26 -08:00
hd64570.h net: Spelling s/transmition/transmission/ 2014-01-14 17:11:26 -08:00
hd64572.c drivers/net: delete non-required instances of include <linux/init.h> 2014-01-16 11:53:26 -08:00
hd64572.h net: Spelling s/transmition/transmission/ 2014-01-14 17:11:26 -08:00
hdlc.c WAN: HDLC: Call notifiers before and after changing device type 2015-12-05 17:41:42 -05:00
hdlc_cisco.c WAN: HDLC: Call notifiers before and after changing device type 2015-12-05 17:41:42 -05:00
hdlc_fr.c WAN: HDLC: Call notifiers before and after changing device type 2015-12-05 17:41:42 -05:00
hdlc_ppp.c WAN: HDLC: Call notifiers before and after changing device type 2015-12-05 17:41:42 -05:00
hdlc_raw.c WAN: HDLC: Call notifiers before and after changing device type 2015-12-05 17:41:42 -05:00
hdlc_raw_eth.c WAN: HDLC: Call notifiers before and after changing device type 2015-12-05 17:41:42 -05:00
hdlc_x25.c WAN: HDLC: Call notifiers before and after changing device type 2015-12-05 17:41:42 -05:00
hostess_sv11.c net: wan: remove deprecated IRQF_DISABLED 2013-10-07 15:53:52 -04:00
ixp4xx_hss.c net: wan: remove unnecessary platform_set_drvdata() 2013-05-27 22:34:52 -07:00
Kconfig net: wan: add missing virt_to_bus dependencies 2015-01-29 15:08:21 -08:00
lapbether.c netfilter: Remove spurios included of netfilter.h 2015-06-18 21:14:32 +02:00
Makefile wanrouter: completely decouple obsolete code from kernel. 2013-01-31 19:20:33 -05:00
n2.c drivers/net: Remove unnecessary k.alloc/v.alloc OOM messages 2012-01-31 16:20:21 -05:00
pc300too.c PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use 2014-08-12 12:15:14 -06:00
pci200syn.c PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use 2014-08-12 12:15:14 -06:00
sbni.c net: wan: sbni: fix device usage count 2015-09-05 17:32:53 -07:00
sbni.h sbni endian fixes 2008-01-18 14:44:33 -05:00
sdla.c net: set name_assign_type in alloc_netdev() 2014-07-15 16:12:48 -07:00
sealevel.c net: wan: remove deprecated IRQF_DISABLED 2013-10-07 15:53:52 -04:00
wanxl.c wan: wanxl: add pci_disable_device in case of error 2015-12-14 16:21:58 -05:00
wanxl.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
wanxlfw.inc_shipped Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
wanxlfw.S Fix the wanxl firmware to include missing constants 2012-11-09 16:28:37 -05:00
x25_asy.c x25_asy: Free x25_asy on x25_asy_open() failure. 2016-01-13 11:45:39 -05:00
x25_asy.h wan: Remove extern from function prototypes 2013-09-24 16:40:19 -07:00
z85230.c Doc: z8530book: Fix typo in API-z8530-sync-txdma-open.html 2015-07-10 23:45:31 -07:00
z85230.h wan: Remove extern from function prototypes 2013-09-24 16:40:19 -07:00